ci: rename branch-protection caller job id to branch-protection - #147
ci: rename branch-protection caller job id to branch-protection#147rubenvdlinde wants to merge 1 commit into
branch-protection#147Conversation
…ction` GitHub names a reusable-workflow status context `<caller-job-id> / <called-job-name>`, so this caller reported as `protect / check-branch` while the org ruleset requires `branch-protection / check-branch`. Also repoints the reusable workflow from `Conduction/.github` to `ConductionNL/.github`. The `Conduction` org does not exist (404), so on this branch the workflow could not resolve at all — a second, independent reason the required context never reported.
|
Reviewed as part of an end-to-end sweep of this repo's open PRs. Correct, and deliberately left for a human — this targets Two separate defects are fixed here, and the second is not in the title:
Worth noting for whoever merges: the diff cannot be validated by CI in the usual way, because the check it repairs is precisely the one that is not reporting. The evidence is the context-name mechanic above plus the fact that No action from me — flagging only so this is not mistaken for a stale duplicate of #146. |
|
Closing as superseded —
Verified by comparing the PR head against the base rather than by reading the title: both resolve to the same caller job id. This is the same disposition as ConductionNL/pipelinq#685, which was the first of this family I looked at and where the branch had additionally gone stale by 571 commits. Nothing here needs carrying forward. Note that the sibling PR targeting |
GitHub names a reusable-workflow status context
<caller-job-id> / <called-job-name>.This branch's caller job id was not
branch-protection, so the shared branch-protectionworkflow reported under the wrong context name, and the org ruleset requirement
branch-protection / check-branchnever reported at all — not as a failure, as nothing.Several of these beta branches carry a second, independent fault: the reusable workflow was
referenced as
Conduction/.githubinstead ofConductionNL/.github. TheConductionorg does notexist (
GET /repos/Conduction/.github-> 404), so on those branches the workflow could not evenresolve. Where present, that is fixed here too — renaming the job id alone would not have made the
context appear.
This matters for
beta -> mainpromotion PRs, whose head isbeta, so beta's tip is whatdecides the context name and the workflow reference.
Does not change what is required and does not touch any ruleset or branch protection.