Release: merge development into beta - #520
Merged
Merged
Conversation
…jects (#519) keepiq was held back from the fleet's vitest 4 adoption because it is the one app using `environmentMatchGlobs`, which vitest removed in 4. Without it every DOM spec loses jsdom and dies with `ReferenceError: window is not defined`. The split it expressed is real and worth keeping: the crypto specs use WebCrypto from `globalThis.crypto` and are faster on node, while the component specs mount SFCs and need a document. So it is now two projects, both `extends: true` so they inherit the timeouts, setupFiles, stubs and inlined deps configured once at the root. Only name, environment and include differ, which is the whole of what environmentMatchGlobs did. One spec also had to be fixed rather than carried. `tests/store/export.spec.js` installs spies on SHARED prototypes (HTMLAnchorElement.prototype.click, Storage.prototype.setItem) in `beforeEach` and never restored them, so each test stacked another wrapper on the same method and calls accumulated. That is a latent leak, not a vitest 4 regression: it made `expect(clickSpy).not.toHaveBeenCalled()` observe two clicks the test never made. An `afterEach` restore fixes it at the source. Verified: 92 test files and 669 tests pass at exit 0, npm ci and npm run build both exit 0.
Contributor
Quality Report — ConductionNL/keepiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 111/111 | |||
| npm | ✅ | ✅ 536/536 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-30 14:09 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated promotion.
developmentholds 1 commit(s)betadoes not.