fix(ci): required check branch-protection / check-branch never reported — job id was protect - #256
Merged
Merged
Conversation
…quired context never reported The org rulesets "Main Branch Protection" and "Beta Branch Protection" require the status context `branch-protection / check-branch`. GitHub composes a reusable-workflow context as `<caller-job-id> / <called-job-name>`, and this caller job was named `protect` — so the check that actually got emitted was `protect / check-branch` and the required one never appeared. Every PR to main or beta therefore sat permanently pending on a check that could not arrive, and only `--admin` could merge. Same defect petstore had (petstore#20). larpingapp has both `beta` and `development`, so the branch topology the shared check-branch job requires (development -> beta, beta|hotfix/* -> main) is satisfied and making the gate report does not newly block anything.
Contributor
Quality Report — ConductionNL/larpingapp @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| composer | ✅ | ✅ 101/101 | |||
| npm | ✅ | ✅ 537/537 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ✅ |
Quality workflow — 2026-08-04 11:57 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The org rulesets Main Branch Protection and Beta Branch Protection both require the status context
branch-protection / check-branch.GitHub composes a reusable-workflow status context as
<caller-job-id> / <called-job-name>. This caller's job id wasprotect, so the context it actually emitted wasprotect / check-branch.The required context therefore never reported at all. Every PR to
mainorbetasat permanently pending on a check that could not arrive, and only--admincould ship it. A dead gate whose absence looks exactly like its success.Same defect as ConductionNL/petstore#20.
Fix
Job id
protect→branch-protection, plus a comment recording why the name is load-bearing.Why this does not newly block anything
Making a never-reporting check report is only safe if it will pass. The shared
check-branchjob requires:maincome frombetaorhotfix/*betacome fromdevelopment,main, orhotfix/*larpingapp has both
betaanddevelopment, so the required topology is satisfied. (petstore had neither, which was a second, independent fault there.)Still outstanding after this PR
betaadditionally callsConduction/.github/...— the retired Codeberg org name, which GitHub Actions cannot resolve at all.mainhas nobranch-protection.ymlat all.Both are handled by follow-up PRs to those protected branches.