chore: adopt Nextcloud's coding standard, .editorconfig and NC 34 - #106
Open
rubenvdlinde wants to merge 8 commits into
Open
chore: adopt Nextcloud's coding standard, .editorconfig and NC 34#106rubenvdlinde wants to merge 8 commits into
rubenvdlinde wants to merge 8 commits into
Conversation
Configuration only. The reformat is the next commit on purpose, so .git-blame-ignore-revs can name a revision containing nothing but whitespace. - .php-cs-fixer.dist.php + conduction/coding-standard, which extends nextcloud/coding-standard and can only ADD to it — enforced by that package's invariant test, not by review. - cs:check / cs:fix now run php-cs-fixer. They were aliases for phpcs/phpcbf, so the documented Nextcloud command reformatted code AWAY from Nextcloud's standard. - nextcloud/coding-standard dropped as a direct dependency. It arrives transitively at a version conduction/coding-standard has tested against; declared directly it was a dead dependency with no config and no invocation. - phpcs.xml is now a stub over the shared semantics-only ruleset, and the local phpcs-custom-sniffs/ copy is gone. The fleet was carrying six divergent versions of NamedParametersSniff.php — a custom RULE, not a setting. - .editorconfig, verbatim from nextcloud/server. No fleet app had one, so an editor configured by someone's previous Nextcloud work defaulted to tabs, which the old ruleset then rejected. - nextcloud/ocp -> ^34.0 and PHPUnit -> stable34. This app declared support for NC 34 while being analysed against 31, so a symbol REMOVED in 32/33/34 was invisible to the type checker. That is why the NC 34 removal of \OC::$server needed a hand-written PHPCS sniff. - the stylelint glob is quoted, so stylelint expands it rather than the shell. Unquoted, src/**/ matches exactly one directory level and nested components are silently unlinted. gate-65 (coding-standard-adoption) enforces all of the above from ConductionNL/.github@main. This app failed it; with this commit it passes.
Applied by php-cs-fixer with conduction/coding-standard. Tabs, same-line braces, (int)$x, single-space concatenation, ordered imports — Nextcloud's dialect, which this app now passes unchanged. 476 file(s), no behaviour change. Isolated from the configuration change so .git-blame-ignore-revs can name a revision that touches nothing but formatting. Reviewing it line by line is not a useful activity; the previous commit is the review.
46e028e touches 476 files and changes no behaviour. Without this, every line it reflowed attributes to it and the real author is one --skip away. GitHub honours the file automatically; locally it needs `git config blame.ignoreRevsFile .git-blame-ignore-revs` once.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
August 12, 2026 10:01
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ❌ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ❌ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| composer | ❌ | ❌ | |||
| npm | ✅ | ✅ 548/548 | |||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ❌ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-12 10:07 UTC
Download the full PDF report from the workflow artifacts.
The previous commit changed composer.json without touching the lock, so
`composer install` refused with exit 4 and EVERY PHP job failed:
Required (in require-dev) package "conduction/coding-standard" is not
present in the lock file.
Required (in require-dev) package "conduction/hydra-gates" is not present
in the lock file.
Required (in require-dev) package "nextcloud/ocp" is in the lock file as
"v31.0.9" but that does not satisfy your constraint "^34.0".
Nothing was wrong with the reformat or the ruleset — the jobs never got as far
as running a tool. Measured on larpingapp#313 before this fix: phpcs, psalm,
phpstan and both PHPUnit legs red, all of them at `composer install`. Hydra
Gates passed in the same run, because it does not install composer
dependencies.
Now locked at conduction/coding-standard v1.0.0, conduction/hydra-gates v1.7.0,
nextcloud/ocp v34.0.2 — the last of which is the point of the exercise: this app
declares support for NC 34 and is now analysed against it.
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 548/548 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-12 10:27 UTC
Download the full PDF report from the workflow artifacts.
The App Store's info.xsd declares <info> and its children as xs:sequence, so element ORDER is significant. This file was rejected by `xmllint --noout --schema info.xsd appinfo/info.xml`. Nextcloud's lint-info-xml workflow validates against exactly that schema, and ConductionNL/.github#383 adds the same check to the shared pipeline. Elements were moved into the schema's order. <version> and the <nextcloud> min/max-version declaration are unchanged. <commands> now precedes <settings>, and <navigations> follows <activity>; inside <repair-steps>, <post-migration> precedes <install> (the schema's order is pre-migration, post-migration, live-migration, install, uninstall - it does not reflect execution order, which Nextcloud selects by event). Two content fixes were unavoidable, as neither is an ordering problem. <types><search/></types> is not a valid app type at any position: the schema allows only prelogin, filesystem, authentication, extended_authentication, logging, dav, prevent_group_restriction and session, and Nextcloud does nothing with an unrecognised one. Unified search is already wired properly - Application.php calls registerSearchProvider(LaunchPadSearchProvider) - so the element was decorative. Replaced by a comment pointing at that registration. <activity><provider> had to be wrapped in <providers>. The direct child is what the schema rejects, and Nextcloud reads the provider list from $info['activity']['providers']['provider'], so the Activity provider (REQ-ACT-001) was in fact not being registered at all. The wrapping is therefore a behaviour change: OCA\LaunchPad\Activity\Extension now actually registers, which is what the requirement asked for. Verified: `xmllint --noout --schema info.xsd appinfo/info.xml` reports "validates" (libxml2 2.12.10). The pre-change file failed the same command.
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 548/548 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-12 11:02 UTC
Download the full PDF report from the workflow artifacts.
dev-master has advanced to the Nextcloud 35 development stubs, where ISchemaWrapper::createTable()/getTable() return the new OCP\DB\Schema\ITable (@SInCE 35.0.0) rather than being documented as returning \Doctrine\DBAL\Schema\Table. That made PHPStan report 17 genuine parameter-type mismatches in the Migration table builders, which type-hint Doctrine\DBAL\Schema\Table. The app declares <nextcloud min-version="32" max-version="34"/>, so analysing against NC 35 development stubs was wrong regardless. Pinning to ^34.0 matches the constraint used by every other app in this migration (softwarecatalog, hermiq, pipelinq) and by the merged reference larpingapp#313. PHPStan is now clean; no application code changes.
The previous run produced zero jobs and concluded failure: it started inside the window where ConductionNL/.github@main carried the broken quality.yml splice from b745bf2f, repaired at 4118bca8. Nothing in this PR touches the workflow.
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 548/548 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ❌ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-12 13:01 UTC
Download the full PDF report from the workflow artifacts.
OCP\ICache is untyped on every Nextcloud version this app supports — 'get($key)', 'set($key, $value, $ttl = 0)', 'hasKey($key)', 'remove($key)', 'clear($prefix = "")' — identical in server stable32 and stable34. The three in-test fakes narrowed every parameter to string/int, which PHP rejects as an incompatible declaration: PHP Fatal error: Declaration of Unit\Activity\FakeDebounceCache::get( string $key) must be compatible with OCP\ICache::get($key) They only ever loaded because the app resolved nextcloud/ocp at dev-master, which has advanced to the NC 35 development stubs where ICache::get() IS typed. Pinning ocp to ^34.0 lines the stub up with the servers this app actually declares support for, and the fakes then have to line up too. Return types are left in place — widening a parent's absent return type is covariant and legal. Parameter types only; no test behaviour changes. The three affected files run green: OK (39 tests, 80 assertions).
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 548/548 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-12 13:30 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the fleet-wide move to Nextcloud's coding standard. Recipe proven on nextcloud-app-template#142; enforced from
ConductionNL/.github@mainby gate-65 coding-standard-adoption, which this app fails today and passes with this PR.Policy: Conduction code must pass Nextcloud's own checks unchanged. We may be stricter, never different.
Three commits, deliberately separated
chore:configstyle:reformatchore:blame-ignore.git-blame-ignore-revsnaming the reformatWhat changed
.php-cs-fixer.dist.php+conduction/coding-standard, which extendsnextcloud/coding-standardand can only add to it — enforced by that package's invariant test, not by review.cs:check/cs:fixnow actually run php-cs-fixer. They were aliases forphpcs/phpcbf, so the documented Nextcloud command reformatted code away from Nextcloud's standard.nextcloud/coding-standarddropped as a direct dependency — it arrives transitively at a tested version. Declared directly it was a dead dependency with no config file and no invocation anywhere.phpcs.xmlis a stub over the shared semantics-only ruleset; the localphpcs-custom-sniffs/copy is gone. The fleet was carrying six divergent versions ofNamedParametersSniff.php— a custom rule, not a setting..editorconfig, verbatim fromnextcloud/server. No fleet app had one.nextcloud/ocp→^34.0, PHPUnit →stable34. This app declared support for NC 34 while being analysed against 31, so a symbol removed in 32/33/34 was invisible to the type checker — which is why the NC 34 removal of\OC::$serverneeded a hand-written sniff.src/**/matches exactly one directory level and nested components go unlinted.Verification
Reformatted with a shared php-cs-fixer across all 18 apps: 9,656 files, 0 remaining findings anywhere. Every changed PHP file re-linted with
php -l.Expect red
This app's base branch already fails several quality jobs, and moving to NC 34 will surface more. That is intended — the point is to align with Nextcloud, not to keep the board green.