feat(chrome): give launchpad a Reports page with one honest report - #537
Merged
Conversation
ADR-114 puts Documentation, Reports and Features & roadmap in the footer in that order. LaunchPad had two of the three, with room at 95. One card, deliberately. LaunchPad's register holds a single schema — dashboard — so a second report would either repeat this one or invent a reading the data cannot support. The `widgets` array holds widget descriptors rather than references, so grouping by it would bucket objects and render noise; it is left out rather than shipped as a chart that looks like an answer. The e2e asserts the count, so a schema added later without a report is something a test notices. The report is a declarative type:dashboard page over the app's own register. No bespoke Vue component and no per-app controller. Every filter is scalar equality, the only kind OpenRegister's aggregation endpoint can evaluate. Ten strings across all 36 locales. Parity passes on development and still passes here.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
September 3, 2026 18:26
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 526/526 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-03 18:31 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR-114 puts Documentation, Reports and Features & roadmap in the app's footer, in that order. LaunchPad had two of the three, with room at 95.
One card, deliberately
LaunchPad's register holds a single schema —
dashboard. A second report would either repeat this one or invent a reading the data cannot support, so there is one: Dashboards — how many there are, and who they belong to (personal, shared with a group, admin template).I left out the obvious-looking second chart.
dashboard.widgetsis an array of widget descriptors, not references, so grouping by it would bucket objects and render noise. A chart that renders something is not the same as a chart that answers something, and this is a page people will read numbers off.The e2e asserts the card count, so if a schema is added later and no report follows, that is something a test notices rather than something nobody sees.
Pure manifest
The report is a declarative
type: "dashboard"page over LaunchPad's own register — no bespoke Vue component, no per-app controller. Every filter is scalar equality, the only kind OpenRegister's aggregation endpoint can evaluate.The spec asserts a digit reaches the page, not just that the card exists: a widget naming a schema or field that does not match renders its chrome and no value, silently.
Checks
app-chrome:{"status":"passed","checked":5,"failed":0,"warned":1}— the warning is the Store entry, a separate rolloutChartBoxOutlineregistered; this app registers only a handful of icons)check:manifest: validlint:translation-domain: OKcheck-l10n-paritypasses ondevelopmentand still passes here🤖 Generated with Claude Code