docs(select): name the two dropdown fixes apart, so neither is deleted alone - #562
Merged
Merged
Conversation
…d alone Correcting my own description in #561. It said nc-vue declares `--vs-dropdown-z-index` on `body` as 9999. That is true of nc-vue's chunk stylesheet, and it is ALSO true of this app's own `css/launchpad.css`, which re-declares it there deliberately under ConductionNL/nextcloud-vue#864 because nc-vue 9.10 moved the declaration onto the select root where an appended menu cannot inherit it. Leaving that out made the new rule look like it replaced the old one. It does not. They fix different halves and removing either brings a different failure back: css/launchpad.css restores INHERITANCE, so the menu receives a value. src/styles/workspace.css raises the VALUE above NcModal, which assigns itself a runtime z-index counting up as modals open — measured 10005 for the first and 10010 for the second. Every one beats 9999, so the #864 workaround alone still leaves the menu under any modal. That matters because #864 is open and ends with "delete both once upstream fixes the scoping". Whoever closes it will read this file, and now finds a line saying the 10100 rule must stay until nc-vue relates the two numbers rather than choosing them independently. Both comments now point at each other. Comment-only. No rule changes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
September 6, 2026 06:42
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 527/527 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-06 06:45 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correcting my own description in #561
That PR said nc-vue declares
--vs-dropdown-z-indexonbodyas 9999. True of nc-vue's chunk stylesheet — and also true of this app's owncss/launchpad.css, which re-declares it there deliberately under ConductionNL/nextcloud-vue#864, because nc-vue 9.10 moved the declaration onto the select root where an appended menu cannot inherit it.Leaving that out made the new rule look like it replaced the old one. It does not.
They fix different halves
css/launchpad.csssrc/styles/workspace.cssNcModal, which assigns itself a runtime z-index counting up as modals open (measured 10005 for the first, 10010 for the second)Every one of those beats 9999, so the #864 workaround alone still leaves the menu under any modal. Removing either rule brings a different failure back.
Why this needs saying now
#864 is open and ends with "delete both once upstream fixes the scoping". Whoever closes it will read
css/launchpad.css— and now finds a line saying the 10100 rule must stay until nc-vue relates the two numbers rather than choosing them independently.Both comments now point at each other. The measurement is also on #864 itself.
Scope
Comment-only. No rule changes.
🤖 Generated with Claude Code