feat(shell): adopt CnAppRoot manifest-first shell (ADR-024 Tier-4) - #28
Merged
Conversation
Implements issue #21 — replaces the custom-router + OpenRegisterGuard app shell with a manifest-driven CnAppRoot shell per hydra ADR-024 §8/§9. Frontend: - src/manifest.json: 6 pages (Dashboard, Courses, Enrolments, Credentials, Compliance, Settings) + 7 menu items bound to OR register/schema pairs; $schema points at the canonical app-manifest.schema.json - src/main.js: rewritten — imports bundledManifest, builds vue-router from manifest.pages, renders CnAppRoot; no app-local router config - src/App.vue: simplified wrapper around CnAppRoot with translate prop - src/views/ScholiqSettings.vue: new custom settings page (OR register picker, AiFeature read-only table, credential signing key widget) - tests/validate-manifest.js: Ajv validator for src/manifest.json - package.json: pin @nextcloud/axios ~2.5.2 (CJS export required by @nextcloud/vue CJS barrel); bump @conduction/nextcloud-vue to ^1.0.0-beta.13; add check:manifest script PHP (ADR-031 legitimate seams only): - lib/Controller/PageController.php: index() + catchAll() + manifest() (ADR-024 §4 bundled blob endpoint, v0.2 override hook deferred) - lib/Service/Cmi5LaunchTokenService.php: RS256 JWT mint stub (full impl in course-management change) - lib/Lifecycle/AiFeatureDpoAckGuard.php: DPO-ack guard for AiFeature lifecycle transitions (ADR-031 PHP seam) - lib/Settings/scholiq_register.json: replace example schema with AiFeature schema (x-openregister-lifecycle + x-openregister-notifications) - lib/AppInfo/Application.php: cleaned — no AdminSettings/PersonalSettings - appinfo/routes.php: full wedge route table (10 routes + catch-all) - appinfo/info.xml: hard <dependency> for openregister + openconnector, NC min-version 33, PHP 8.3/8.4; remove OCP Settings registration (now manifest-driven) Quality: composer check:strict PASS, npm run lint PASS, npm run build PASS, npm run check:manifest PASS
Contributor
Quality Report — ConductionNL/scholiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ❌ | ❌ | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-11 20:20 UTC
Download the full PDF report from the workflow artifacts.
This was referenced May 11, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Files changed
Frontend:
PHP:
Test plan