feat(course-management): apply wedge spec via manifest-first declaration (closes #22) - #30
Merged
Merged
Conversation
…ion (closes #22) Adds Course, Lesson, and XapiStatement schemas to scholiq_register.json with full x-openregister-lifecycle / calculations / aggregations / relations / notifications declarations per ADR-022/024/031. Extends src/manifest.json with CourseDetail (type: detail), LessonIndex (type: index), LessonDetail (type: detail), and LessonPlayer (type: custom) pages — all resolved by CnAppRoot built-in renderers. No PHP service classes added; CoursePublishGuard (lifecycle guard) and the four ADR-031 exception controllers/services are deferred to separate PRs per the spec's Phase 2 task list.
Contributor
Quality Report — ConductionNL/scholiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ❌ | ❌ | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-11 21:49 UTC
Download the full PDF report from the workflow artifacts.
This was referenced May 12, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/Settings/scholiq_register.json: Course, Lesson, XapiStatement — fully declared viax-openregister-*extensions, zero PHP service classes.src/manifest.jsonwith 4 new pages: CourseDetail (type: detail), LessonIndex (type: index), LessonDetail (type: detail), LessonPlayer (type: custom — branches on contentType at runtime).Schemas added
Course (12 properties, 3 lifecycle states)
code,name,name_nl,description,level(enum: po/vo/mbo/hbo/wo/corporate),language,tags,mandatoryTraining,regulationSlug,renewalCourseSlug,certificateTemplate,lifecycle,tenant_idx-openregister-lifecycle:draft → published(guarded byCoursePublishGuard),published → archived,archived → draftx-openregister-calculations:lessonCount(count of child Lessons),isPublished(eq lifecycle=published)x-openregister-aggregations:enrolledLearners(count_distinct from Enrolment),completedLearners(count_distinct, filtered lifecycle=completed)x-openregister-notifications: publish → admin+hr, archive → adminLesson (11 properties, 3 lifecycle states)
courseId,name,order(min: 1),contentType(enum: text/video/scorm12/scorm2004/cmi5/lti/quiz),contentRef,durationMinutes,learningObjectives,mandatoryTraining,regulationSlug,lifecycle,tenant_idx-openregister-relations:coursemany-to-one, joinOncourseIdx-openregister-lifecycle:draft → published,published → retiredx-openregister-notifications: publish → adminXapiStatement (12 properties, appendOnly: true)
actor,verb,object,result,context,timestamp,stored,authority,version(const: 1.0.3),courseId,lessonId,tenant_idappendOnly: true— every save emitsxapi.statement.receivedaudit entry via OR lifecycle enginetransitionsmap — no state changes permitted (LRS substrate)Manifest changes
4 pages added to
src/manifest.json(was 6 pages, now 10):CourseDetail— route/courses/:id, type: detail, register: scholiq, schema: CourseLessonIndex— route/courses/:courseId/lessons, type: index, register: scholiq, schema: LessonLessonDetail— route/courses/:courseId/lessons/:id, type: detail, register: scholiq, schema: LessonLessonPlayer— route/courses/:courseId/lessons/:lessonId/play, type: custom, component: LessonPlayerNo router edits, no Pinia stores, no custom List/Detail Vue files created.
ADR-031 PHP exceptions
None in this PR. The
CoursePublishGuardlifecycle guard and the four spec-mandated controllers/services (LrsController,ScormController,LessonImportController,Cmi5ImporterService,ScormToXapiTranslator) are ADR-031 legitimate exceptions — they will be added in follow-up PRs per the tasks.md Phase 2 list.Validation
python3 -c 'import json; json.load(open("lib/Settings/scholiq_register.json"))'— PASSnode tests/validate-manifest.js— PASS (10 pages, structural lint: 0 issues)