fix(icons): Dutch-government sets resolve Dutch icons (default missing design_system)#190
Merged
Merged
Conversation
Live verification caught it: rijkshuisstijl (and the ~33 Dutch municipality sets) omit design_system in token-sets.json — they carry id/name/description/ theming and rely on the app-wide 'nldesign' default that getAvailableTokenSets()/Capabilities apply. resolveActiveIconPacks() did NOT apply that default, so every Dutch-government set resolved to NO icon pack — silently breaking the 'Dutch government → Dutch icons' promise this wave is about. Fix distinguishes a KNOWN set that omits the field (→ nldesign default → Dutch packs) from an UNKNOWN token set id (empty meta → no pack). The existing 'NldesignDefault' test set design_system explicitly so it never exercised the real omitted-field case; added a regression test with a set that omits it. Verified live: rijkshuisstijl→[rvo,open-gemeenten,den-haag], lasuite→[dsfr], summer-breeze→[], unknown→[]. 527 PHPUnit, check:strict green.
Contributor
Quality Report — ConductionNL/nldesign @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ❌ | ❌ | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-07-25 10:25 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live-verification bug: the ~33 Dutch sets that omit design_system resolved to NO icon pack, breaking the per-government icon promise. Now default a KNOWN design_system-less set to nldesign (→ Dutch packs), while an UNKNOWN id still yields none. 527 tests green.
🤖 Generated with Claude Code