Skip to content

chore(ci): remove dead Forgejo/Codeberg CI residue - #211

Merged
rubenvdlinde merged 1 commit into
developmentfrom
chore/remove-forgejo-ci-residue
Aug 4, 2026
Merged

chore(ci): remove dead Forgejo/Codeberg CI residue#211
rubenvdlinde merged 1 commit into
developmentfrom
chore/remove-forgejo-ci-residue

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Why

Codeberg is retired — ConductionNL is a GitHub-only organisation. GitHub Actions never executes .forgejo/**, so every workflow under it contributed zero status checks. This removes the dead ones.

Deleted (3 of 5)

deleted .forgejo/workflows/… GitHub counterpart
pre-merge-check-strict.yaml .github/workflows/code-quality.yml → shared ConductionNL/.github quality pipeline
app-tests-live.yml + tests-live.yml the e2e/newman layer; the shared workflow's enable-playwright / enable-newman inputs are its GitHub home

Kept on purpose — no GitHub counterpart

  • app-tests.yml + tests.ymltests.yml carries the l10n-check hard gate (node tests/l10n/check-l10n.js, the i18n-extraction-drift guard) plus phpunit-coverage-ratchet / frontend-coverage-ratchet. This repo has no .github/workflows/l10n.yml, does not route test:l10n through the shared workflow's frontend-checks input, and does not set enable-coverage-guard — so these files are the only definition of those gates. Deleting the only copy of a real gate would be a regression rather than a cleanup.

Honest caveat: they do not run anywhere today — the forge that executed them is gone, and npm run test:l10n currently fails on development. Porting the gate to .github/workflows/ would redden CI on arrival, so it must be a deliberate follow-up with the strings backfilled, not a side effect of this cleanup.

Known gap this removes (reported, not silently dropped)

app-tests-live.yml requested run-e2e / run-newman / run-visual; code-quality.yml here enables neither Playwright nor Newman, so that layer is currently un-gated on GitHub. Already true before this PR — the .forgejo copy has never run there.

Also fixed

  • tests/e2e/visual/README.md — the visual project's only CI wiring was the deleted run-visual input; the doc now says plainly it is not wired into CI.

Checks

Note for reviewers: code-quality.yml has no paths: filter, so the full shared quality suite does run on this PR even though the diff is .forgejo/** + markdown. Any failure here is therefore pre-existing development debt, not caused by this diff — this change removes files GitHub Actions never read.

Codeberg is retired; ConductionNL is GitHub-only. GitHub Actions never
executes .forgejo/**, so these workflows contributed zero status checks.

Deleted 3 of 5: pre-merge-check-strict.yaml (covered by
.github/workflows/code-quality.yml) and app-tests-live.yml + tests-live.yml.

KEPT app-tests.yml + tests.yml -- tests.yml carries the only definition of
the l10n extraction gate and the coverage ratchets (no .github/workflows/
l10n.yml here, enable-coverage-guard unset).

Also repointed the .forgejo reference in tests/e2e/visual/README.md.
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/nldesign @ 4ad6c19

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
composer ✅ 100/100
npm ✅ 2/2
PHPUnit
Newman ⏭️
Playwright ⏭️

Quality workflow — 2026-08-04 09:24 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit c05599c into development Aug 4, 2026
30 of 32 checks passed
@rubenvdlinde
rubenvdlinde deleted the chore/remove-forgejo-ci-residue branch August 4, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant