chore(deps): @conduction/nextcloud-vue 3.0.0-vue3.6 - #213
Merged
Conversation
Contributor
Quality Report — ConductionNL/nldesign @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 2/2 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ✅ |
Quality workflow — 2026-08-04 12:54 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
@conduction/nextcloud-vuefrom3.0.0-vue3.4to3.0.0-vue3.6(exact pin, fleet convention).Why — nc-vue #596, a real WCAG 2.4.6 / 1.3.1 fix
Five page primitives (
CnIndexPage,CnSettingsPage,CnChatPage,CnFilesPage,CnLogsPage) gated their<h1>behindv-if="showTitle", andshowTitledefaults tofalse. The title was surfaced in the sidebar instead — which sits outside the<main>landmark — so the main content region carried no heading at all:Measured blast radius: 608 of 625 index-page surfaces across 19 of 20 apps.
3.0.0-vue3.6renders the<h1>unconditionally and visually-clips it whenshowTitleis false (position:absolute+ 1px +clip-path: inset(50%)— notdisplay:none, which would remove it from the accessibility tree too). It is always in the DOM and the accessibility tree. Zero visual change.Checked across all 21 fleet repos (
src/manifest.json+src/manifest.d/*.json): of 1489 declared pages, exactly 3 set a page-levelshowTitle(docudeskTemplates/SigningRequests, petstoreOrders) — and all 3 set it totrue, so they already rendered a visible<h1>and are unchanged by this bump. The other 1486 inherit thefalsedefault and are fixed by the version bump alone — no source change needed here.Verified: rendered-DOM A/B, not a version string
The same mount + query run against both versions, with the header markup and the
showTitledefault extracted programmatically from each version's own source (arms differ only by library version, so.4is the negative control for the query itself):.5is crossed on the way — no regression3.0.0-vue3.5(ADR-079 Step 2) removed the generic admin-settings modal fromCnAppRootand moved the organisation credential broker toCnAdminSettingsShell's new opt-inshow-organisation-credentialsprop.That removed surface was gated on
isOwner && manifest.adminSettings[].length > 0. Verified across all 20 fleet repos (src/manifest.jsonandsrc/manifest.d/*.jsonfragments and all JS/Vue source, with a passing positive control):manifest.adminSettings[]cnOpenAdminSettingsinjectaction: "admin-settings"So the org credential broker rendered in zero apps before this bump and renders in zero after — the removal is dead-code removal, not a UI regression. (OpenRegister's
CnCredentialsinPersonalRoot.vueis the separate personal-scope surface and is untouched.)Lockfile
Regenerated with npm 10.9.9 (matching
engines.npm: ^10) vianpm install --package-lock-only, then verified withnpm ci. Diff is the minimal 4 insertions / 4 deletions — version, resolved URL and integrity hash only.