chore(deps): track @conduction/nextcloud-vue ^2.3.0 - #285
Merged
Conversation
The app pinned the exact prerelease 2.2.0-vue3.16, which is now deprecated: the Vue 3 line was folded into the mainline 2.x release series and ships as 2.3.0 on the `latest` dist-tag. A caret range replaces the exact pin so future 2.x releases roll out without a per-app edit. Drops the `overrides.@conduction/nextcloud-vue.eslint` entry. That override existed only because the old prerelease declared `eslint: ^8.56.0 || ^9.0.0` and could not see the app's eslint 10; 2.3.0 declares `|| ^10.0.0` itself, so the peer resolves without help. No API change: 252 components in and 252 out, no export removed, one added (the BSN validators). Peer ranges are otherwise identical.
Contributor
Quality Report — ConductionNL/nldesign @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 2/2 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-15 17:42 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves
@conduction/nextcloud-vuefrom the exact pin2.2.0-vue3.16to the range^2.3.0, and drops theoverrides."@conduction/nextcloud-vue".eslintentry.Why
The Vue 3 line used to ship as a prerelease series (
2.2.0-vue3.x) alongside a Vue 2latest. That split is gone: the Vue 3 line has been folded into the mainline 2.x series and now ships as 2.3.0 onlatest. All 40vue3.xprereleases — including the2.2.0-vue3.16this app pinned — are deprecated, sonpm installwarns until the pin moves.A caret range instead of an exact pin means future 2.x releases of the shared library reach the app without a per-repo edit.
The
overridesentry existed for exactly one reason: the old prerelease declaredeslint: "^8.56.0 || ^9.0.0"and so could not see this app's eslint 10, which broke peer resolution. 2.3.0 declares"^8.56.0 || ^9.0.0 || ^10.0.0"itself — visible in the lockfile diff — so the workaround is now dead weight.Risk
Low, and measured rather than assumed:
resolved,integrityand the eslint peer string. Zero packages added or removed.Internally the library did move — 2,542 changed lines across 36 files, touching
CnDataTable,CnDetailPage,CnAppNavandCnDashboardGrid— which is why this was verified per app rather than swept.Verification
Run locally against the real 2.3.0 tarball:
node_modulesand the lockfile)npm run buildnpm run lintnpm test