style(phpcs): clear the one phpcs ERROR (inline comment capitalisation) - #360
Merged
Conversation
Precondition for ConductionNL/.github#483, which makes phpcs ERRORS fail the gate. That PR must not land while any repo still carries errors, because `.github@main` is consumed live and the flip reaches every repo the instant it merges. The comment opened with the app's own name, which is deliberately lowercase, so "start with a capital letter" and "spell the app correctly" were in direct conflict. Rephrasing to "This app is served from…" satisfies the sniff without renaming anything or dropping the sentence. Measured, with a control: before, `A TOTAL OF 1 ERROR AND 0 WARNINGS`; after, phpcs exits 0 having scanned 63/63 files — clean, not a no-op run.
Contributor
Quality Report — ConductionNL/nldesign @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 2/2 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-19 16:54 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precondition for ConductionNL/.github#483, which makes phpcs errors fail the gate. That PR must not land while any repo still carries errors —
.github@mainis consumed live, so the flip reaches every repo the instant it merges.The comment opened with the app's own name, which is deliberately lowercase — so "inline comments must start with a capital letter" and "spell the app correctly" were in direct conflict. Rephrasing to "This app is served from…" satisfies the sniff without renaming anything or dropping the sentence.
Measured, with a control: before,
A TOTAL OF 1 ERROR AND 0 WARNINGS; after, phpcs exits 0 having scanned 63/63 files — clean, not a no-op run.