fix(tests,lint): two stale specs pinned removed contracts; arm the Vue 3 lint gate

[rubenvdlinde]

Unit failures — both were stale specs, not flake

Baseline on the unmodified base at load ~3 was 2 failures, not 1:

 FAIL tests/vitest/SaveAsTemplateAction.spec.js > … > openSaveAsTemplate gathers schemas + templates and opens the dialog
 FAIL tests/vitest/views/ExportJobsList.spec.js  > … > filters by the applicationSlug prop

Both are tests still asserting behaviour that a later, correct production fix deliberately replaced. Neither could be noticed, because no app's JS unit suite has ever run in CI (quality.yml's frontend-checks defaults to "[]" and the job is guarded on != '[]').

1. SaveAsTemplateAction — the mock was call-order dependent

The spec queued one axiosMock.get.mockResolvedValueOnce(...) for the templates read. openSaveAsTemplate() now issues two GETs — it resolves the manifest from /api/applications/{slug}/manifest first, then reads templates. The one-shot response was consumed by the manifest call; the templates read fell through to the generic { data: application } default, which has no results array → existingTemplates came back [].

Production is right. The manifest GET was added because an Application record carries neither manifest nor currentVersion, so the old obApp.manifest read always fell through to {} and saving any app as a template was impossible. The mock is now routed by URL, removing the ordering dependency and letting both responses be asserted; the manifest endpoint is now asserted explicitly too.

2. ExportJobsList — the spec pinned the exact bug that was fixed

It asserted filter[applicationSlug]=my-app. Commit c1d22f4f5 (#95) replaced that with a plain ?applicationUuid=, for two independently sufficient reasons measured against real stored jobs: export-job declares no applicationSlug property at all, and the filter[...] bracket syntax is not what the endpoint reads. Production is right; the expectation is corrected, and both ruled-out shapes are now pinned negatively so neither can come back.

No assertion was weakened, skipped, or given a longer timeout.

Lint — adopt @conduction/nextcloud-vue/eslint

eslint --print-config on this Vue 3 app showed zero vue/no-deprecated-* rules armed and vue/no-multiple-template-root armed at [2]. Spreading conductionVue3Fixes last arms 21 deprecation rules and disarms the three inverted Vue-2 rules (the two hand-rolled local disables are now redundant and were removed).

Positive control — because "0 deprecation findings" is meaningless without one. Injecting a beforeDestroy() hook into PageDesigner.vue:

config	result
with shared preset	error … vue/no-deprecated-destroyed-lifecycle
base config (before)	completely silent

That is the same configuration that let four beforeDestroy hooks survive openconnector's Vue 3 migration as silent memory leaks. Sentinel reverted.

Backlog: 9 findings, all fixed — zero deferred

5 × vue/v-on-event-hyphenation, 4 × comma-dangle.

The hyphenation fixes were applied by hand, never via --fix, and only after proving they are semantics-preserving:

<C @update:dataSource="f" />   -> "onUpdate:dataSource"
<C @update:data-source="f" />  -> "onUpdate:dataSource"

@vue/compiler-sfc compiles both spellings to the identical handler key (Vue 3 camelizes a static v-on argument). The config comment removed in this PR asserted the opposite — that the hyphenated form is "silently DEAD" — and that claim is false. All four edited components have their own passing specs.

Positive control for the 0/0 lint baseline: an injected var + unused binding reports 2 errors, so the clean baseline is real and not a misconfigured lint run.

After

140 files / 1364 tests pass, twice, at load ~3-4. npm run lint: 0 errors, 0 warnings.

[github-actions]

Quality Report — ConductionNL/openbuild @ b6c3f5d

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
composer			✅	✅ 100/100
npm			✅	✅ 662/662
PHPUnit					✅
Newman					⏭️
Playwright					⏭️

Coverage: 89.4% (17/19 statements)

---

Quality workflow — 2026-08-02 20:09 UTC

Download the full PDF report from the workflow artifacts.