feat(tools): declare subject and action on the agent tool catalogue - #259
Merged
Merged
Conversation
Part of the fleet-wide taxonomy pass. Measured live against `/apps/hermiq/api/agents/tools`: **87 of 177 tools across the fleet declared no subject or action**, so the agent grant matrix fell back to guessing from the tool id and rendered them as ungroupable one-off rows. 🔴 The reason this went unnoticed is that an undeclared field here is INVISIBLE. `ToolRegistryFacade::describeTools()` deliberately returns null rather than inferring a subject from the id — the right call, since a consumer cannot tell an inferred subject from a real one — so a descriptor missing these keys produces no error, no warning and no failing test.⚠️ The action vocabulary is deliberately NOT closed to CRUD, because the matrix GRANTS on this value. A tool that promotes a release, starts a meeting, renders a forecast or converts a file says so, rather than being filed under the nearest CRUD verb — flattening those would be a security statement, not a naming one. Verified live end-to-end: the endpoint now reports **0** undeclared of 177, across 16 distinct actions and 79 subjects.
Contributor
Quality Report — ConductionNL/openbuild @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| check-gitignore | ✅ | ||||
| check-nc-floor | ✅ | ||||
| format | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 626/626 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ❌ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-19 09:09 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The other half of the ADR-095 grant work: ADR-095 fixed how grants are stored; this declares what they are stored about.
Measured live against
/apps/hermiq/api/agents/tools— 87 of 177 tools across the fleet declared no subject or action, so the grant matrix fell back to guessing from the tool id.🔴 An undeclared field here is invisible.
ToolRegistryFacade::describeTools()deliberately returns null rather than inferring a subject — the right call, since a consumer cannot tell an inferred subject from a real one — so a descriptor missing these keys produces no error, no warning and no failing test. That is how 87 went unnoticed.Verified live end-to-end: 87 → 0 undeclared of 177, across 16 distinct actions and 79 subjects.
Companion PRs: openregister#2574 (the 25 OR tools + the
#[McpTool]attribute), hermiq#380.