fix(rollback): rolling back restored NOTHING — it wrote to two fields the schema does not have

[rubenvdlinde]

The bug

onRollback() {
  obPatchApp({ manifest, version: `${v}-rollback-${hex}`, status: 'draft' })
}

obPatchApp PUTs the whole Application object. The application schema declares 15 properties and neither manifest nor version is one of them, so OpenRegister dropped both. Only status survived — and a rolled-back app is normally already a draft, so the entire feature was a visible no-op.

Measured live, with a control that changes a known property so "the write landed" isn't assumed:

PUT description: 'CONTROL_MARKER_XYZ789'   -> persisted   (PUT landed)
    version:     'PROBE-rollback-deadbeef' -> None        (DROPPED)
    manifest:    {probeMarker: ...}        -> None        (DROPPED)

ApplicationManifestTab already hit this exact trap and moved to PUT /api/applications/{slug}/manifest, leaving a comment saying so. The versions tab was never updated. It now uses that route; round-trip verified independently ({"status":"ok","target":"version"}).

The <version>-rollback-<hex> label is deliberately not reinstated — there's no version property to hold it, and inventing one is a schema change, not a bug fix. shortHex() goes with it; the label was its only caller.

Why the spec never caught it

The blocker note on this file was wrong, and it was mine. It claimed the sidebar "refuses to open — a UI defect to chase on its own" and that getByRole('tab', …) "finds nothing — these are not ARIA tabs".

It was a modal. CnAppRoot offers the setup wizard whenever every required step is met but at least one optional one isn't (optionalSetupGating, REQ-SETUP-NV-012), as a full modal-mask. OpenBuild trips it permanently: its store step carries no required key — "optional" exists only in the title string — so optionalUnmet is never empty. Users dismiss it once via localStorage; every Playwright context is fresh, so it reopened in every test.

That mask sat over the sidebar toggle (→ "visible but not actionable") and marked the background aria-hidden (→ missing tab role). One cause, both symptoms.

document.elementsFromPoint(<centre of the toggle>) named it in one probe — after three wrong theories. New suppressSetupWizard() helper, applied to the four exposed specs.

The spec now has to be able to fail

Two defects in my own test, both caught before shipping:

• Every seeded snapshot carries the same empty manifest, so "restored" and "did nothing" were byte-identical — the assertion could never fail. It now plants a distinct manifest first and asserts it's gone.
• The target was read as "first non-production row in the API response", which is a different row than the first Roll back button on screen — so the spec failed against a working fix. It now reads the semver from the DOM row owning the button it clicks.

It compares menu/pages only (the GET returns an effective manifest with runtime injected and name added), and gets its own fixture (pw-rollback) since it mutates the active manifest twice per run while versionRouting reads /manifest?_version= off pw-verchain.

Three-way verified on the current spec: pre-fix fails (planted manifest survives the rollback), fixed passes 2/2.

Not addressed here

versionRouting has two failures on the shared instance, both independent of this change (they persist with separate fixtures):

• non-member must receive 404 → 401, because globalSetup cannot mint the rbac-outsider session.
• editor must receive the staging manifest → 404, unexplained; I have not investigated it.

🤖 Generated with Claude Code

[github-actions]

Quality Report — ConductionNL/openbuild @ 9413d17

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
composer			✅	✅ 100/100
npm			✅	✅ 659/659
PHPUnit					✅
Newman					⏭️
Playwright					⏭️

Coverage: 89.4% (17/19 statements)

---

Quality workflow — 2026-08-02 16:45 UTC

Download the full PDF report from the workflow artifacts.