fix: replace standalone SBOM with reusable quality workflow - #430
Closed
rubenvdlinde wants to merge 7 commits into
Closed
fix: replace standalone SBOM with reusable quality workflow#430rubenvdlinde wants to merge 7 commits into
rubenvdlinde wants to merge 7 commits into
Conversation
ObjectService::searchObjectsPaginated() does not have a `published` parameter. Passing it caused "Unknown named parameter $published" errors (HTTP 500) on all publications, catalogs, glossary, pages, menus, sitemap, and robots endpoints. Removed `published: false` from 9 call sites across 7 files.
PublicationsController::uses() and ::used() passed `rbac: true`
but ObjectService expects `_rbac: true`. This caused HTTP 500
on /api/{catalogSlug}/{id}/uses and /used endpoints.
…r-i18n specs Bug fix: - Router: added name properties to all 11 routes (was blocking clickable-kpi-widgets) New specs: - woo-transparency: WOO publication workflow (moved from docudesk) - prometheus-metrics: Prometheus metrics endpoint (/api/metrics, /api/health) - register-i18n: Multi-language content (most translation-heavy app) Implementation: - MetricsController: publications by status/catalog, catalogs, listings, search - HealthController: database connectivity check - Dashboard: KPI cards migrated to CnStatsBlock with route props
…pack alias The import from @conduction/nextcloud-vue had no webpack alias and no npm dependency, breaking builds on GitHub CI. Adds the npm package as a dependency and a conditional webpack alias that uses the local source when available (monorepo dev) and falls back to npm otherwise. Also adds deduplication aliases for vue/pinia/@nextcloud/vue.
…e quality workflow Replace the 176-line standalone quality-check.yml and separate sbom.yml with a single reusable workflow caller from ConductionNL/.github, which provides PHPCS, PHPMD, SBOM generation, and frontend checks in one job.
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (131 total)
PHPUnit TestsPHPUnit tests were not enabled for this run. Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
Collaborator
Author
|
Closing — superseded by newer work or stale (3+ months). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quality-check.ymland separatesbom.yml, replacing both with a single reusable workflow caller (ConductionNL/.github/.github/workflows/quality.yml) that provides PHPCS, PHPMD, SBOM generation, and frontend checkspublishedparameterCommits
11539f73fix: replace standalone quality-check and SBOM workflows with reusable quality workflow7bcbdf5cfix: replace standalone SBOM workflow with reusable quality workflow6a422c7bfix: Add @conduction/nextcloud-vue npm dependency and conditional webpack alias7e7adc53feat: Add named routes, prometheus metrics, woo-transparency, register-i18n specs6379a8dbfix: Correct named parameter for uses/used endpointsf05d35fefix: Remove invalid published parameter from ObjectService calls