fix(deps): root @nextcloud/l10n 3.x (app would not boot) + nc-vue 3.0.0-vue3.4 - #1136
Merged
Conversation
….0-vue3.4
Two dependency corrections; the first is a HARD BOOT FAILURE.
1. @nextcloud/l10n ^2.0.1 -> ^3.4.1
nc-vue BUNDLES @nextcloud/dialogs and @nextcloud/password-confirmation into
its dist (dist/esm/node_modules/@nextcloud/...). That bundled code calls
`getGettextBuilder().detectLanguage()` at MODULE INIT. detectLanguage exists
on @nextcloud/l10n 3.x and does NOT exist on 2.2.0, which is what ^2.0.1
resolved to at the app root.
Result: 'TypeError: (0, rs.$)(...).detectLanguage is not a function' and the
Vue app never mounts — the Nextcloud shell renders, the app does not. The
nested copies under node_modules/@nextcloud/{dialogs,files,vue}/ are already
3.4.1; only the root was behind, and the root is what webpack resolves the
bundled code against.
Reproduced across three consecutive clean builds (including a full `npm ci`
from the committed lockfile) and ruled out against controls: openbuild on the
same instance mounted fine, a stale-chunk wipe changed nothing, and reverting
the nc-vue pin did NOT fix it. Bumping the root l10n did: 0 console errors,
27 nav entries.
2. @conduction/nextcloud-vue 3.0.0-vue3.2 -> 3.0.0-vue3.4
Picks up the ADR-079 admin-settings link-out. Verified it is genuinely in the
published tarball rather than trusting a green Release run: vue3.2 ships 0
files containing showAdminSettingsLink and 9 containing the removed
cnOpenAdminSettings; vue3.4 ships the new API.
Live-verified after rebuild + clean redeploy — the settings foldout now reads:
Settings
Personal settings
Admin settings -> /settings/admin/openconnector (401 for anon)
no duplicate 'Settings' child, 24 nav entries, 0 console errors. That is the
first time the ADR-079 link has rendered in any app.
eslint clean; gate failure set identical to origin/development (15 = 15).
Contributor
Quality Report — ConductionNL/openconnector @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| build | ✅ | ||||
| composer | ✅ | ✅ 153/153 | |||
| npm | ✅ | ✅ 692/692 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ✅ | ||||
| Playwright | ❌ |
Quality workflow — 2026-08-03 22:28 UTC
Download the full PDF report from the workflow artifacts.
This was referenced Aug 3, 2026
Contributor
Quality Report — ConductionNL/openconnector @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| build | ✅ | ||||
| composer | ✅ | ✅ 153/153 | |||
| npm | ✅ | ✅ 692/692 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ |
Quality workflow — 2026-08-03 22:51 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two dependency corrections. The first is a hard boot failure on
development.1.
@nextcloud/l10n^2.0.1→^3.4.1nc-vue bundles
@nextcloud/dialogsand@nextcloud/password-confirmationinto its dist (dist/esm/node_modules/@nextcloud/…). That bundled code callsgetGettextBuilder().detectLanguage()at module init.detectLanguageexists on@nextcloud/l10n3.x and does not exist on 2.2.0 — which is what^2.0.1resolves to at the app root.Result:
…and the Vue app never mounts. The Nextcloud shell renders, the app does not — 0
data-testidnodes, no navigation.The nested copies under
node_modules/@nextcloud/{dialogs,files,vue,password-confirmation}/are already3.4.1. Only the root was behind, and the root is what webpack resolves the bundled code against.Controls run before concluding
npm cifrom the committed lockfile, clean rebuildjs/(9 stale chunks) and redeployed2.
@conduction/nextcloud-vue3.0.0-vue3.2→3.0.0-vue3.4Picks up the ADR-079 admin-settings link-out (nextcloud-vue#593).
Verified the feature is genuinely in the published tarball rather than trusting a green Release run:
vue3.2ships 0 files containingshowAdminSettingsLinkand 9 containing the removedcnOpenAdminSettings;vue3.4ships the new API.Live verification
After rebuild + clean redeploy, the settings foldout now reads:
/settings/admin/openconnectorreturns 401 for an anonymous caller — the platform authorizes it server-side, which is the whole point of ADR-079 §3. No duplicateSettingschild. 24 nav entries, 0 console errors.This is the first time the ADR-079 link has rendered in any app.
Checks
eslint clean. Hydra gate failure set identical to
origin/development(15 = 15, compared by name).