ADR cleanup pass — openregister coverage-report.md Bucket 4

[WilcoLouwerse]

ADR Conformance Follow-up

Generated by /opsx-coverage-scan openregister on 2026-04-30 as part of the retrofit pass tracked in ConductionNL/.github#27. These findings are noise during retrofit but worth addressing in a separate cycle.

Bucket 4 findings

1. print_r() call in SchemaMapper (ADR-003 / forbidden-debug-calls)

File	Line	Finding
lib/Db/SchemaMapper.php	892	print_r() used for string conversion — replace with json_encode() or (string) cast

Fix: replace print_r($value, true) with json_encode($value) or (string) $value.

2. Direct SQL calls (ADR-001 / ADR-003)

8 occurrences of $this->db->prepare() bypassing QueryBuilder. These are in low-level cross-table query paths where QueryBuilder cannot express the required SQL, but need review for MariaDB compatibility (mariadb-ci-matrix spec intent):

File	Lines
lib/Service/RegisterService.php	442
lib/Service/Object/ReferentialIntegrityService.php	373, 902
lib/Service/Object/LinkedEntityEnricher.php	121, 161, 247, 301, 347, 400
lib/Service/Object/CacheHandler.php	1770

Action: verify each SQL statement is MariaDB-compatible and add a comment explaining why QueryBuilder cannot be used here.

What to do

• Fix SchemaMapper.php:892 — replace print_r() with json_encode()
• Audit the 8 db->prepare() calls for MariaDB compatibility
• Add inline comment to each db->prepare() site explaining why raw SQL is necessary

Source

openspec/coverage-report.md generated 2026-04-30 as part of the openregister retrofit (PRs #1364, #1365, #1368). Parent tracking issue: ConductionNL/.github#27.

[WilcoLouwerse]

PR opened: #1432 (targets development, will auto-close this issue on merge).

What's done

• ✅ SchemaMapper.php:892 — print_r($value, true) → json_encode($value).
• ✅ All 10 db->prepare() raw-SQL sites carry an inline comment explaining why QueryBuilder cannot be used. The issue body summary said "8" but the table actually lists 10 occurrences — all are covered.

MariaDB audit findings

The audit also surfaced two real MariaDB-incompat bugs (not just style), fixed in the same PR since the codebase already had portable counterparts to mirror:

1. ReferentialIntegrityService.php:372 — bare current_schema() is PostgreSQL-only and would fail on MariaDB. Now branches on platform (DATABASE() for MySQL/MariaDB, current_schema() for PostgreSQL), mirroring MagicMapper.php:1697-1707.
2. RegisterService.php:418 — CAST(... AS VARCHAR) (no length) is non-standard on MariaDB. Now branches on platform (CAST AS CHAR for MariaDB/MySQL, CAST AS VARCHAR for PostgreSQL), mirroring MagicMapper.php:1346-1349.

Per-site audit table

File	Line	Why raw SQL	MariaDB status
RegisterService.php	442	UNION ALL across N dynamically-named magic tables	✅ after CAST fix
ReferentialIntegrityService.php	373	information_schema.tables metadata query	✅ after current_schema() fix
ReferentialIntegrityService.php	902	Platform-conditional JSON_CONTAINS / jsonb @> operators	✅ already platform-aware
LinkedEntityEnricher.php	121	Foreign Mail-app table (oc_mail_messages)	✅
LinkedEntityEnricher.php	161	Foreign DAV/Contacts table (oc_cards)	✅
LinkedEntityEnricher.php	247	Foreign DAV/Calendar table (oc_calendarobjects)	✅
LinkedEntityEnricher.php	301	Foreign DAV/Calendar table (oc_calendarobjects)	✅
LinkedEntityEnricher.php	347	Foreign Talk-app table (oc_talk_rooms)	✅
LinkedEntityEnricher.php	400	Foreign Deck-app tables (joined cards/stacks/boards)	✅
CacheHandler.php	1770	Runtime-resolved magic table + name column from fixed allowlist	✅