retrofit: annotate openregister Bucket 1 (169 methods / 96 REQs)#1365
Merged
WilcoLouwerse merged 8 commits intofeature/reverse-specfrom Apr 30, 2026
Merged
Conversation
…ethods Adds pre-destruction notification REQ (objects approaching archiefactiedatum trigger per-object Nextcloud notifications to archivaris group, configurable lead time, deduplication via app config). Ghost change archived. Annotates 11 Bucket 2a methods with @SPEC refs: - DestructionCheckJob::run, sendObjectNotification → REQ-009 task - LegalHoldService: placeHold, releaseHold, hasActiveHold, hasActiveHoldFromRetention, bulkPlaceHold → REQ-006 (task-5) - ArchivalController: createLegalHold, releaseLegalHold → REQ-006 (task-5) - ArchivalService: calculateArchivalDate → REQ-007 (task-6) - ArchivalService: findObjectsDueForDestruction → REQ-001 (task-1) 9 private/plumbing methods in cluster left unannotated (by design). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…gnore-revs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…Q-NNN format Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
destroyMultiple() was calling logService->deleteLogs() and returning 200, while its sibling destroy() correctly returned 405 Method Not Allowed. Both now enforce the audit-trail-immutable spec: audit trail entries cannot be deleted via any route. Also refresh coverage-report.md/.json from 2026-04-30 rescan. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Applied @SPEC tags pointing at ghost change retrofit-annotate-openregister-2026-04-30. 96 tasks, 26 capabilities. No logic changes. Source: openspec/coverage-report.md (2026-04-30). Continues from retrofit-annotate-openregister-2026-04-23 which covered the bulk of the codebase. This run adds annotations for Bucket 1 methods identified in the fresh coverage scan. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Cleanup of leftover deletions from the archive move. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrofit — Annotation Only
Applies
@spec openspec/changes/retrofit-annotate-openregister-2026-04-30/tasks.md#task-Ntags per ADR-003 §Spec traceability.Ghost change:
openspec/changes/archive/retrofit-annotate-openregister-2026-04-30/(empty spec delta, 96 tasks).Continues from
retrofit-annotate-openregister-2026-04-23which covered the bulk of the codebase. This run targets Bucket 1 methods identified in the 2026-04-30 coverage scan that were not yet annotated.What this PR does
@spectags across 67 files@spectags where missing.git-blame-ignore-revsWhat this PR does NOT do
/opsx-reverse-specPRs)Bucket 1 NEEDS-REVIEW (4 entries skipped)
4 NEEDS-REVIEW entries from the coverage report were intentionally skipped — they require human verification before annotating. One of those (
AuditTrailController::destroy) has been hand-reviewed and the review surfaced a real spec violation in sibling methoddestroyMultiple(), which is fixed in commit 763da8c on the parent branch.Verification
composer phpcspasses (0 errors, 0 warnings).git-blame-ignore-revsincludes the annotation commit (7334a97)Source:
openspec/coverage-report.mdgenerated 2026-04-30🤖 Generated with Claude Code