fix(flow): attribute interactive test runs to the caller (3rd instance of the ownerless-run defect) - #2171
Merged
Conversation
FlowRunController::test() queued its run without the acting user — the same defect as or#2158 in FlowMcpToolProvider::runFlow(), in the one dispatch path that has a session by definition. Consequence: the run was ownerless, so context['triggeredBy'] was null and every attribution-requiring node refused. ObjectWriteNode returned 'This flow run has no owner (triggeredBy); an object write must be attributable.' The interactive 'run this flow now' button could therefore never exercise a write node — the only runs that appeared to work were harness runs with a hand-injected context. Live-verified end to end after this fix, on a naturally triggered run with no injected context: status=completed, triggeredBy=admin, log shows write1 completed itemsIn=1 itemsOut=1, and the object landed in hydra-cache (findings 7 -> 8, owner=admin) read back through the API.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 174/174 | |||
| npm | ✅ | ✅ 555/555 | |||
| PHPUnit | ❌ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-07-27 18:07 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2169, same defect class, third instance.
Problem
FlowRunController::test()queued its run without the acting user — in the one dispatch path that has a session by definition.Consequence: the run was ownerless,
context['triggeredBy']was null, and every attribution-requiring node refused.ObjectWriteNodereturned "This flow run has no owner (triggeredBy); an object write must be attributable." So the interactive "run this flow now" button could never exercise a write node — the only runs that appeared to work were harness runs carrying a hand-injected context.Why this mattered for verification
This is what made the earlier "object-write is proven" claim overstated. The node had 387 passing unit tests and a green live run, but that run's context was injected by the harness. On every real path the node refused.
Live proof, after the fix
A naturally triggered run, nothing injected:
And the object actually landed, read back through the API:
Related
While proving this, two other things surfaced and are filed separately: the live instance was 57 commits behind
origin/developmentso the #2169 fix was not deployed (environment, not code), and #2170 —FlowRunWorkeris never registered inoc_jobs, so asynchronous runs still cannot execute regardless of attribution.🤖 Generated with Claude Code