docs(flow): onConflict:fail IS a lock now — the warning saying otherwise is stale - #2233
Merged
rubenvdlinde merged 1 commit intoJul 31, 2026
Merged
Conversation
…ise is stale `ObjectWriteNode`'s docblock still carried:⚠️ NOT YET SAFE FOR MUTUAL EXCLUSION — openregister#2212. The underlying guard is a check followed by a write, so concurrent flow runs can all pass the check and several succeed. That was true of #2212 and stopped being true at #2215, where the database arbitrates through the `_uuid` unique constraint and the losing writer is told. Re-measured through THIS node rather than inherited from the fix's own PR: twelve simultaneous flow runs claiming one identifier produced 1 completed / 11 stopped each loser: An object with identifier "…" already exists exactly ONE row in the table The stale warning mattered more than a stale comment usually does. It sat on the one primitive hydra's per-issue lock needs — `hydra-flows-first-port` task 3.1 records per-issue locking as having "no node equivalent" — and it said precisely the thing that would stop somebody building it.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 174/174 | |||
| npm | ✅ | ✅ 616/616 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-07-31 14:51 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ObjectWriteNode's docblock still carried:That was true of #2212 and stopped being true at #2215, where the database arbitrates through the
_uuidunique constraint and the losing writer is told.Re-measured through this node, not inherited from the fix's PR
Twelve simultaneous flow runs claiming one identifier:
Why a stale comment mattered here more than usual
It sat on the one primitive hydra's per-issue lock needs.
hydra-flows-first-porttask 3.1 records per-issue locking as having "no node equivalent" — and this warning is what would stop somebody building it. The capability had been there since #2215; only the documentation said otherwise.