chore: untrack phpmetrics-deps/, generated output .gitignore already lists - #2352
Merged
Merged
Conversation
…lready lists 39 files of PHPMetrics HTML report scaffolding were committed despite .gitignore:30 already listing /phpmetrics-deps/. Nothing in the repo reads these paths — PHPMetrics writes to phpmetrics/ (composer.json) and phpqa/phpmetrics (.phpqa.yml), never phpmetrics-deps/. They also carried third-party code into an EUPL-1.2 repo, including js/clusterize.min.js (GPLv3, (c) 2015 Denis Lukov) and MIT-licensed js/sort-table.min.js and css/milligram.min.css. Untracked only; the files stay on disk and remain ignored.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 173/173 | |||
| npm | ✅ | ✅ 713/713 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-05 19:05 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Author
|
Merging: fully green — 27 SUCCESS, 4 SKIPPED, 0 failures.
The diff is 39 deletions, every one under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Stops tracking
phpmetrics-deps/— 39 files of generated PHPMetrics HTML report scaffolding. The files stay on disk; they are only removed from the index (git rm -r --cached).Why
1.
.gitignorealready lists it. Line 30 is/phpmetrics-deps/. The directory was committed anyway, so the ignore rule has been inert.git check-ignore -vconfirms the rule matches every path once untracked:2. It is build output, not source. PHPMetrics never writes to this path:
composer.json:45-48→--report-html=phpmetrics,phpmetrics/report.json, ….phpqa.yml:44-45→--report-html=phpqa/phpmetrics,--report-json=phpqa/phpmetrics/metrics.json3. Nothing references it. Grepping every tracked file outside the directory for
phpmetrics-depsreturns exactly one hit — the.gitignoreentry itself. No workflow, script, config, doc or source file reads these paths, so removing them cannot break a build or a report.4. It dragged third-party licences into an EUPL-1.2 repository. The bundle vendors, among others:
js/clusterize.min.js— GPLv3,Copyright (c) 2015 Denis Lukovjs/sort-table.min.js— MIT,Copyright (c) 2006-2013 Tyler Uebelecss/milligram.min.css— MIT,Copyright (c) 2016 CJ Patoiloplus bundled Roboto/Material-Icons font binaries and
d3. None of it is ours, none of it is used, and it is the only non-EUPL licensed material left in the repository. Untracking it removes the contamination without relicensing anyone else's work — these files are not touched or rewritten, only dropped from the index.Scope
39 deletions, every one under
phpmetrics-deps/; no other path is touched.