Skip to content

chore(ci): move hydra-gates-ref v1.3.0 -> v1.4.0 - #2360

Merged
rubenvdlinde merged 1 commit into
developmentfrom
chore/hydra-gates-ref-v1.4.0
Aug 6, 2026
Merged

chore(ci): move hydra-gates-ref v1.3.0 -> v1.4.0#2360
rubenvdlinde merged 1 commit into
developmentfrom
chore/hydra-gates-ref-v1.4.0

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

What

Moves this repo's hydra-gates-ref pin from v1.3.0 to v1.4.0 in .github/workflows/code-quality.yml. One line of config; the rest of the diff is the comment recording why.

Why

quality.yml is consumed at @main, but the gates package is pinned per-caller. A pinned ref is a silent expiry date on every upstream fix — this repo cannot receive a gate-package change until this line moves. That has already bitten this programme twice:

  • 22 repos pinned v1.0.1 predating a batch of fixes, leaving 16 gates dead fleet-wide (ConductionNL/.github#159);
  • a require-full-coverage default flipped on @main reached v1.0.1 runners that predate the coverage accounting, producing exit 98 (ConductionNL/.github#173).

v1.4.0 is the latest tag and is the only tag containing hydra-gates/scripts/axe-run.cjs — verified absent at v1.3.0, present at v1.4.0. So at v1.3.0 this repo could not use enable-axe: true at all, and had neither #168's axe DOM scoping nor #165's gate-46 fix.

Explicitly not in this PR

enable-axe: true is not set. Ordering matters: the ref lands first. Enabling axe is a separate decision — a vanilla Nextcloud 34 still reports serious/critical violations on core's own routes that DOM scoping does not remove.

Verification

v1.4.0 gates more than v1.3.0, so a Hydra Gates verdict that changes here is a real finding, not a sweep artefact. The failing-job set is compared against this repo's own development baseline before merge; genuine gate findings are reported, not silenced.

Part of a 15-repo consumer-ref sweep.

A pinned `hydra-gates-ref` is a silent expiry date on every upstream fix:
this repo cannot receive a gate-package change until this line moves.

v1.4.0 is the latest tag and the first one that carries
`hydra-gates/scripts/axe-run.cjs` (verified absent at v1.3.0), so it is
also the first that has ConductionNL/.github#168 axe DOM scoping and
ConductionNL/.github#165 gate-46 fix.

`enable-axe` is deliberately NOT enabled in this commit. Ordering matters:
the ref lands first, enabling axe is a separate decision.
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/openregister @ 3376727

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-specs
test-l10n
composer ✅ 173/173
npm ✅ 713/713
PHPUnit
Newman
Playwright
Hydra gates

Quality workflow — 2026-08-05 22:05 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit 604bf46 into development Aug 6, 2026
31 checks passed
@rubenvdlinde
rubenvdlinde deleted the chore/hydra-gates-ref-v1.4.0 branch August 6, 2026 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant