fix(deps): php_codesniffer 3.13.6 — CVE-2026-67434 — plus 2 pre-existing phpcs errors - #2371
Merged
Merged
Conversation
…hpcs errors Security squizlabs/php_codesniffer 3.13.5 -> 3.13.6. OS command injection, GHSA-hmqg-cxww-wqhq / CVE-2026-67434, reported 2026-08-05. Affected: <3.13.6 | >=4.0.0,<4.0.2. All 16 fleet repos checked were on 3.13.5. Pre-existing phpcs errors, fixed here per the always-fix-pre-existing rule lib/Db/Webhook.php and lib/Migration/Version002003000Date20251013000000.php both had a file docblock with no short description. These are NOT caused by the phpcs bump — proven by an explicit A/B on the same tree: arm A phpcs 3.13.5 -> rc=1, 4 ERROR lines arm B phpcs 3.13.6 -> rc=1, 4 ERROR lines, byte-identical after stripping ANSI codes Each arm's version string was asserted before running, so the two arms really did differ; the first comparison I wrote matched nothing in EITHER arm and was discarded as worthless. 3.13.6 introduces no new findings — development was simply already red. Verified - composer audit --locked: 'No security vulnerability advisories found' (was 1). - vendor/bin/phpcs --version -> 3.13.6. - composer phpcs: rc=1 before -> rc=0 after. - php -l clean on both edited files. - Positive control: a deliberately non-conforming file under lib/ made phpcs exit 2 with 13 findings. Probe removed. - config.platform.php is 8.3 here; the run above was on a host PHP where the vendor tree parses, so the rc=0 is a real pass and not a parse-error 255.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 173/173 | |||
| npm | ✅ | ✅ 713/713 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-06 12:12 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New advisory, fleet-wide
squizlabs/php_codesniffer — CVE-2026-67434 / GHSA-hmqg-cxww-wqhq — OS command injection. Reported 2026-08-05. Affected:
<3.13.6 | >=4.0.0,<4.0.2. All 16 Conduction repos checked were on 3.13.5, so this is currently failingSecurity (composer)fleet-wide.The advisory landed mid-session:
composer audit --lockedreturned zero advisories for this repo about an hour before it returned this one.Also: two pre-existing phpcs errors
developmentwas already red on phpcs before this PR:lib/Db/Webhook.phplib/Migration/Version002003000Date20251013000000.phpBoth had a file docblock with no short description. Fixed here per the always-fix-pre-existing rule.
These are not caused by the bump. I ran an explicit A/B on the same tree:
Each arm's
--versionwas asserted before running, so the arms genuinely differed. (My first comparison matched nothing in either arm — a 0-vs-0 "identical" that proved nothing — and was discarded.)Verification
composer audit --locked→ "No security vulnerability advisories found" (was 1).vendor/bin/phpcs --version→ 3.13.6.composer phpcs→ rc=1 before → rc=0 after.php -lclean on both edited files.lib/made phpcs exit 2 with 13 findings, then was deleted.config.platform.phpis8.3; the run above was on a host PHP where the vendor tree parses, so the rc=0 is a real pass and not a parse-error 255.