Skip to content

Fixes for validation code that was removed by someone on accident - #61

Merged
WilcoLouwerse merged 3 commits into
developmentfrom
fix/CONNECTOR-121/missing-validation-code
Nov 11, 2024
Merged

Fixes for validation code that was removed by someone on accident#61
WilcoLouwerse merged 3 commits into
developmentfrom
fix/CONNECTOR-121/missing-validation-code

Conversation

@WilcoLouwerse

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread lib/Service/ObjectService.php Outdated
*
* @return ValidationResult The validation result from opis/json-schema.
*/
public function validateObject(array $object, ?int $schema = null, object $schemaObject = new stdClass()): ValidationResult

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to rename $schema => $schemaId to make things a bit more clear

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, thanks!

@WilcoLouwerse

Copy link
Copy Markdown
Contributor Author

Tested by @RalkeyOfficial
image

@WilcoLouwerse
WilcoLouwerse merged commit 462e896 into development Nov 11, 2024
@WilcoLouwerse
WilcoLouwerse deleted the fix/CONNECTOR-121/missing-validation-code branch November 11, 2024 12:27
rubenvdlinde pushed a commit that referenced this pull request Jul 30, 2025
…lidation-code

Fixes for validation code that was removed by someone on accident
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants