ci: align workflows with fleet standard (ConductionNL/.github) - #16
Merged
Conversation
Wires the repo to the ConductionNL/.github reusable workflows so the two org-required check contexts are reported on every PR. PHP-only profile: npm/frontend legs off (no package.json), SBOM off (no CycloneDX plugin yet), features check off (no openspec).
WilcoLouwerse
approved these changes
Aug 3, 2026
WilcoLouwerse
left a comment
WilcoLouwerse
left a comment
There was a problem hiding this comment.
APPROVE — CI/CD alignment PR looks good. One minor drift from the fleet standard noted inline (missing permissions: block on code-quality.yml).
WilcoLouwerse
previously approved these changes
Aug 3, 2026
WilcoLouwerse
left a comment
WilcoLouwerse
left a comment
There was a problem hiding this comment.
Re-review: fleet CI-standardisatie voor de PHP-only ExApp (enable-npm: false, enable-frontend: false, enable-sbom: false, enable-features-extract: false). Geen nieuwe commits sinds vorige APPROVE; herbevestig.
Prior 🟡 heads-up over ontbrekend caller-level permissions: block op code-quality.yml staat open — valt onder scope-creep policy voor deze fleet-migratie en kan in een follow-up. Blokkeert deze PR niet.
APPROVE.
The caller's permissions block is a static ceiling for every job in the called quality.yml — including disabled ones — so it must cover the widest declared grant. Also satisfies CodeQL actions/missing-workflow-permissions. Matches opentalk/openklant." git push origin feature/workflow-update
SudoThijn
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Aligns this repo's CI with the fleet standard shared workflows in
ConductionNL/.github(reference: openregister).
Depending on the branch this fixes/adds:
branch-protection.ymlwith caller job idbranch-protection→ check reports asbranch-protection / check-branch(required by the org ruleset)code-quality.ymlas a thin wrapper around the sharedquality.yml→ checks report asquality / …Conduction/.githubreferences (org doesn't exist; correct org isConductionNL)Why
Required checks match on exact names. Wrong job ids, the org typo, and legacy workflow
names left PRs hanging on "Expected — waiting for status to be reported".
The corrected checks run on this PR itself (PR workflows run from the source branch),
so a green merge box here is the proof it works.
After merge
Update the branch protection of
main/betato require the newquality / …contextsand remove any stale
PHP Quality/Frontend Qualityentries.