ci: bound CI job runtimes with timeout-minutes - #12
Merged
Conversation
Every job in these workflows ran unbounded, so a hung runner could burn the full 6h GitHub default before failing. Bounds are set from observed fleet-wide durations (successful + failed executions; skipped records excluded) and are deliberately loose --- a timeout that fires under normal contention turns a slow run into a phantom defect. lint-check 15 min (median 0.6 min, max 1.4 min, n=176) validate 20 min (median 0.5 min, max 3.2 min, n=162) l10n 15 min (median 0.1 min, max 1.1 min, n=193) openapi 20 min (max 1.0 min, n=5) Additions only; no job logic, step, or trigger is changed.
Contributor
Quality Report — ConductionNL/petstore @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| test-unit | ✅ | ||||
| check-specs | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 778/778 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-08-03 12:59 UTC
Download the full PDF report from the workflow artifacts.
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
timeout-minutesto every CI job in this repo that lacked one. Additions only — no job logic, step, trigger, orruns-onis changed.Why
These jobs ran unbounded, so a hung runner (network stall, wedged
npm ci) could burn the full 6 hour GitHub default before failing, holding a concurrency slot the whole time.Bounds
Measured from observed fleet-wide durations — successful and failed executions, with skipped records excluded (those otherwise drag every median to zero):
lint-checkvalidatel10nopenapiBounds are deliberately loose — roughly 6-25x the observed max. A timeout that fires under normal runner contention is worse than no timeout at all, because it converts a merely slow run into a phantom defect. Please do not tighten these without new measurements.
Verification
Each touched file was re-parsed with PyYAML to confirm it still parses, the job set is unchanged, and each job carries exactly the intended value. Jobs not in scope were confirmed to still report no timeout. The check was itself positive-controlled (a deliberately mutated value was detected).