fix(e2e): reach Portfolio by its card, which is its only entry point - #580
Merged
Merged
Conversation
`Portfolio renders capacity` clicked a nav entry titled "Portfolio". There is none: the report moved onto the Reports page as a card labelled "Capacity" — ADR-112, a report is a card OR an entry, never both — so the click waited out its 60s timeout on a locator that can never resolve, which reads as a broken page. This is the first failure this suite has ever reported. It never ran before: the seed asked for the `timeEntry` slug that #575 renamed, exited 1, and took Playwright with it. 1 failed, 34 passed is the first real tally. `openReportCard()` sits beside `navigateTo()` and addresses the card by its own testid and title span, NOT by the link's accessible name: CnReportsPage wraps title, description and category in one anchor, so an exact match on the label finds nothing. A liveness control goes first, so a card that does not match reads as a missing card rather than a page that never mounted. Verified: the "Capacity" card names page Portfolio, which routes to /portfolio — the URL the test still asserts. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Author
Contributor
Quality Report — ConductionNL/planninq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ❌ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 536/536 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-05 15:01 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first failure this suite has ever reported. It never ran before: the seed asked for the
timeEntryslug that #575 renamed toplannedTimeEntry, exited 1, and took Playwright with it. #578 fixed the seed, and the push run came back 1 failed, 34 passed — the first real tally this app has.The one failure:
Portfolio renders capacityclicks a nav entry titledPortfolio. There is none. The report moved onto the Reports page as a card labelled Capacity — ADR-112, a report is a card or a menu entry, never both — so the click waited out its full 60 s on a locator that can never resolve, which reads as a broken page.openReportCard()sits besidenavigateTo()and opens a report through its card. It addresses the card by its owndata-testid="cn-report-card"and title span, not by the link's accessible name:CnReportsPagewraps title, description and category in one anchor, so the accessible name is all three concatenated and an exact match on the label finds nothing. That mistake cost stackiq a 60 s timeout earlier today. A liveness control goes first, so a card that does not match reads as a missing card rather than a page that never mounted.Verified
eslintandplaywright test --listare green (9 tests collect). The chain was checked against the real manifest: the Capacity card names pagePortfolio, which routes to/portfolio— the URL the test still asserts.🤖 Generated with Claude Code