fix(dashboard): calendar-aligned range presets, and the real caseType label field - #732
Merged
Merged
Conversation
… label field Two companion fixes to nextcloud-vue#600. The dashboard's range presets were rolling windows labelled as calendar ones: `days: 30` on 21 May covers 22 April–21 May, so "Month" misstated what the numbers cover. They now use the `period` preset kind added in nextcloud-vue#600, which resolves to the CURRENT calendar unit to date, and are relabelled accordingly. The "Cases by Type" chart resolved its labels through `labelField: "name"`, but the caseType schema has NO `name` property — only `title`. The chart worked purely by accident, falling through to the `@self.name` fallback. Corrected to the field that actually exists. `statusType` genuinely has `name`, so that one is untouched. Both depend on nextcloud-vue#600 being released on the vue3 line; the preset change is inert until then (an unknown preset kind resolves to null and the previous window stands), and the labelField change is an improvement either way.
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 550/550 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-05 12:57 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two companion fixes to nextcloud-vue#600.
Presets were rolling windows wearing calendar labels
days: 30on 21 May covers 22 April – 21 May. Labelling that "Month" misstates what the numbers cover. They now use theperiodpreset kind added in nextcloud-vue#600, which resolves to the current calendar unit to date, and are relabelled "Current week/month/quarter/year".The chart was resolving labels through a field that does not exist
"Cases by Type" used
labelResolve.labelField: "name", but thecaseTypeschema has nonameproperty — onlytitle. The chart worked purely by accident, falling through to the@self.namefallback. Corrected to the field that actually exists.statusTypegenuinely hasname, so that one is untouched.Sequencing
Both depend on nextcloud-vue#600 landing and releasing on the vue3 line. The preset change is inert until then — an unknown preset kind resolves to null and the previous window stands — and the labelField correction is an improvement either way. Manifest validates against the v2 schema.