ci(procest): enable SBOM — the ELSPROBLEMS blocker is stale - #738
Merged
Conversation
The npm SBOM step in the shared workflow now passes --ignore-npm-errors, which is exactly the flag that neutralises the @conduction/nextcloud-vue npm ls ELSPROBLEMS failure this was switched off for (#434). Verified against a positive control rather than assumed: docudesk pins the same @conduction/nextcloud-vue 2.2.0-vue3.3 and its SBOM job completed the npm leg and merged the PHP + npm SBOMs (run 31016019235, job 92340789907). openregister, opencatalogi and doriath are green on SBOM as well, so the old comment's 'No other Conduction app enables SBOM today' no longer holds. procest already requires cyclonedx/cyclonedx-php-composer ^6.2 and allows the plugin, so the composer leg has its prerequisite.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
August 5, 2026 15:06
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 550/550 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-05 15:28 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable-sbomhas beenfalsein procest's caller since the shared workflow's npm SBOM step could be broken by@conduction/nextcloud-vue'snpm lstree failing ELSPROBLEMS (#434).That blocker is stale. The shared workflow now runs:
--ignore-npm-errorsis precisely the flag that neutralises ELSPROBLEMS, and it was not present when this was switched off.Measured positive control, not assumed: docudesk pins the same
@conduction/nextcloud-vue@2.2.0-vue3.3this repo pins, and its SBOM job ondevelopmentran the npm leg to completion and merged the PHP + npm SBOMs — run 31016019235, job 92340789907. openregister, opencatalogi and doriath are green on SBOM too, so the old comment's closing line ("No other Conduction app enables SBOM today") is now false.procest already ships the other prerequisite:
composer.jsonrequirescyclonedx/cyclonedx-php-composer ^6.2and allows its plugin.Note on where this reports
SBOM's
if:testsgithub.refagainstrefs/heads/{main,beta,development}. On a pull request the ref isrefs/pull/N/merge, so this job cannot run on this PR — it first reports on the merge todevelopment. That is the shared workflow's design, not a defect in this change.No skip, waiver,
continue-on-erroror threshold change was added.