chore(deps): axe-core is a testing library — move it to devDependencies - #757
Merged
Conversation
axe-core sat in `dependencies`, declaring an accessibility *testing* library as an application runtime dependency. Measured: nothing under src/ imports axe-core, and the built bundle never contained it (webpack only emits what the import graph reaches). What put it in every app manifest is a bogus peerDependency on `axe-core: ^4.10.0` declared by @conduction/nextcloud-vue, which does not import it either. Real accessibility scanning uses @axe-core/playwright, and the hydra WCAG gate injects axe from cdnjs — neither needs this entry. Not a bundle-size fix; the bundle is unchanged. It stops a test dependency being declared as production surface (SBOM, `npm ci --omit=dev`, advisory triage). devDependencies still satisfy nc-vue's peer. Verified: npm ci + production build both exit 0.
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 552/552 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-06 13:32 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 552/552 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-06 14:02 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
axe-core sat in
dependencies, declaring an accessibility testing library as an application runtime dependency.Measured, not assumed
src/imports axe-core — 0 hits foraxe-core/axe.run.js/foraxe-core,axe.run, and axe's own signature strings (aria-allowed-attr,color-contrast). Positive control: those same strings match 20 files undernode_modules/axe-core, so the grep can find axe when axe is there — the zero is a real absence, not a broken search.@conduction/nextcloud-vuedeclares axe-core as an OPTIONAL peerDependency (peerDependenciesMeta["axe-core"].optional === true). nc-vue does use it, but only insrc/testing/a11y.js— a testing helper that is never imported fromsrc/index.js, so it never reaches an app bundle. nc-vue's own file header states axe-core "is a devDependency" and that consumers wanting the a11y assertion "addaxe-coreto their OWN devDependencies". This change follows that instruction.@axe-core/playwright, and the hydra WCAG gate injects axe from cdnjs.What this actually fixes
Not bundle size — the bundle is byte-identical. It stops a test dependency being declared as production surface, which matters for SBOM generation, for
npm ci --omit=devrelease installs, and for advisory triage. An optional peer is satisfied by a devDependency, so nothing breaks.Verification
npm ci(npm 10.8.2, matchingengines) → exit 0axe-corestill present innode_modulesafter install--legacy-peer-deps. Using--legacy-peer-depshere strips everypeer: trueentry and produces a ~12k-line deletion; the intended diff is 3 lines.Replicates ConductionNL/doriath#174.