fix(nav): stop the domain settings page claiming the platform's "Settings" - #760
Merged
Merged
Conversation
…ings"
gate-63 (ADR-079) blocks EVERY procest manifest edit, not just one PR. It
reports PASS on development only because it SKIPS when the manifest is not in
the diff — so the first PR to touch src/manifest.json inherits two failures it
did not cause. procest#758 hit exactly that.
D1 page 'Settings' is a type:settings page whose id and title claim the
platform meaning of Settings, while app configuration belongs at
/settings/admin/<app>.
D4 a settings-foldout entry labelled 'Settings' inside a foldout button
already called Settings — the nav literally renders Settings > Settings.
FIXED BY RENAMING, NOT DELETING, and the distinction matters. The gate's WARN
suggests deleting the in-app page as a duplicate of lib/Settings/AdminSettings
.php. It is not a duplicate: CaseTypesMenu routes to this same page, so it
HOSTS the case-type management surface — the one admin-settings.spec.ts
asserts renders "its management surface and add control". Deleting it would
have removed a live surface to satisfy a lint. D1's own wording allows the
safe remedy: "a domain page that happens to be called settings must be
RENAMED".
page id Settings -> ProcestConfiguration
page title Settings -> Configuration
section Settings -> Configuration
SettingsMenu label Settings -> Configuration (D4)
THE ROUTE PATH /settings IS DELIBERATELY UNCHANGED. It is a bookmarkable URL,
the gate keys on id/title rather than path, and pages.spec.ts navigates to
/index.php/apps/procest/settings three times.
A page id IS its vue-router route name, so the rename has real callers:
src/views/DoorlooptijdDashboard.vue pushed { name: 'Settings' } from the
"Go to Settings" empty-state button — updated, or that button would have
navigated nowhere.
tests/e2e/navigation.spec.ts targets the gear foldout by testid and still
passes: the foldout legitimately says "Settings". Its comment warned about
colliding with the SettingsMenu entry, which is precisely the collision D4
describes and this commit removes — comment updated to say so.
ALSO FIXES the pre-existing gate-45 finding this pulled into scope: three
skeleton loaders in DoorlooptijdDashboard.vue animate indefinitely with no
prefers-reduced-motion fallback (WCAG 2.3.3). An indefinite pulse is what
someone with vestibular sensitivity sets that preference to avoid. The
animation is now dropped under the media query and replaced with a dimmed
static state, so a skeleton still reads as "not real data yet" rather than
becoming indistinguishable from a loaded card.
Verified: ALL 59 APPLICABLE GATES GREEN, all 59 ran; check:manifest passes
(58 pages, 0 ajv errors). gate-63's remaining output is the non-blocking
duplicate-home WARN, which stands as a genuine question for the PO rather
than something to silence by deleting a working screen.
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 552/552 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-07 11:20 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gate-63(ADR-079) blocks every procest manifest edit, not just one PR. It reports PASS ondevelopmentonly because it skips when the manifest is not in the diff — so the first PR to touchsrc/manifest.jsoninherits two failures it did not cause. #758 hit exactly that.Settingsis atype:settingspage whose id and title claim the platform meaning of Settings, while app configuration belongs at/settings/admin/<app>Settingsinside a foldout button already called Settings — the nav literally renders Settings > SettingsRenamed, not deleted — and the distinction matters
The gate's WARN suggests deleting the in-app page as a duplicate of
lib/Settings/AdminSettings.php. It is not a duplicate.CaseTypesMenuroutes to this same page, so it hosts the case-type management surface — the oneadmin-settings.spec.tsasserts renders "its management surface and add control". Deleting it would have removed a live surface to satisfy a lint.D1's own wording allows the safe remedy: "a domain page that happens to be called settings must be renamed".
The route path
/settingsis deliberately unchanged — it is a bookmarkable URL, the gate keys on id/title rather than path, andpages.spec.tsnavigates to it three times.A page id is its vue-router route name, so the rename had real callers
src/views/DoorlooptijdDashboard.vuepushed{ name: 'Settings' }from the "Go to Settings" empty-state button. Updated — otherwise that button would have navigated nowhere.tests/e2e/navigation.spec.tstargets the gear foldout by testid and still passes: the foldout legitimately says "Settings". Its comment warned about colliding with theSettingsMenuentry — which is precisely the collision D4 describes and this PR removes. Comment updated to say so.Also fixes the gate-45 finding this pulled into scope
Three skeleton loaders in
DoorlooptijdDashboard.vueanimate indefinitely with noprefers-reduced-motionfallback (WCAG 2.3.3). An indefinite pulse is what someone with vestibular sensitivity sets that preference to avoid. The animation is now dropped under the media query and replaced with a dimmed static state, so a skeleton still reads as "not real data yet" rather than becoming indistinguishable from a loaded card.Verified
check:manifestpasses (58 pages, 0 ajv errors).Unblocks #758.