fix(install): run the twelve seed steps on a FRESH install, not only on upgrade - #824
Merged
Merged
Conversation
Nextcloud runs migrateSchemaOnly() on a first install: $previousVersion is '', so Installer::installAppLastSteps() skips BOTH pre-migration and post-migration, and <install> is the only unconditional hook. The upgrade path runs pre/post-migration and NOT install, so an app needs both blocks carrying the same baseline steps, each idempotent. Until now this app declared no <install> block at all, so the Procest register and twelve seed steps never arrived on a fresh instance. Only baseline-CREATING steps are added; migrations, backfills, renames and cross-app ingests stay upgrade-only so they never run against an empty database. <install> is placed after </post-migration> per the info.xsd sequence (pre-migration, post-migration, live-migration, install, uninstall), verified against the schema.
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
August 12, 2026 19:09
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 552/552 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-12 19:37 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Procest declared no
<install>block, so on a fresh instance the register was never imported and not one of the twelve seed steps ran — no ZGW mappings, no bezwaar/beroep data, no LHS or VTH matrices, no workflow templates.Why post-migration never runs on a first install
\OC\Installer::installAppLastStepsguards both pre- and post-migration withif ($previousVersion !== ""), and$previousVersionis""on a first install ($ms->migrate("latest", true)→migrateSchemaOnly()). Only<install>runs unconditionally. The upgrade path runs pre/post-migration and notinstall, so both blocks are needed, with idempotent steps.Added (13 baseline creators)
InitializeSettings,LoadDefaultZgwMappings,SeedBezwaarBeroepData,SeedBezwaarWorkflowDefinition,SeedBesluitvormingTemplates,RegisterOriRegister,SeedLhsMatrix,SeedVthMatrixCells,SeedVthWorkflowTemplates,VthSeedDataRepairStep,SeedDeadlineMonitoringData,SeedKccWerkplekData,SeedVerwerkingsactiviteitenAll verified idempotent from their own docblocks before inclusion.
Deliberately excluded
MigrateWorkflowDefinitionsRenameDutchDeadlineColumnsMigrateArchivalToOpenRegisterBackfillInformatieobjectMetadataLinkInFlightContractDecisionsRepair,LinkInFlightRemainingDecisionsRepair<install>sits after</post-migration>per theinfo.xsdsequence, verified against the schema.Part of a sweep; openconnector and shillinq already carry this block.
🤖 Generated with Claude Code