refactor(stuf)!: rename inkomend to inbound, and test the guard nobody watched

[rubenvdlinde]

What

1. Renames the Dutch inkomend StUF receiver to inbound — method, route name, canonical URL, log messages and docblocks.
2. Adds the test suite it never had: 5 tests, and deleting the WSSE guard makes them red.

The guard was real but unwatched

inbound() verifies a WSSE UsernameToken and answers 422 on mismatch. Nothing tested it. No test in the repo referenced the endpoint at all — delete the verifyWsse() call and every test stayed green.

Its two sibling public routes already had that cover in StufSoapRequestDispatcherAuthTest, whose docblock states the standard exactly right: these are #[PublicPage] routes, nothing in Nextcloud's middleware will refuse a caller, so the refusal has to come from the app and has to be tested. This applies that standard to the third route.

The negative control

Guard deleted → 2 failures, and the informative one is this: logInbound was called with a tampered envelope. The message was accepted and recorded. Guard restored → 5/5 green.

test	what it pins
testATamperedWsseTokenIsRefused	422, and logInbound is never reached — an endpoint that records first and refuses second has already accepted the message
testAnUnresolvableEndpointIsRefused	400, and verifyWsse is never called
testAnEmptyBodyIsRefused	400 before anything is resolved
testAVerifiedSenderIsProcessedAndAcknowledged	the positive control — without it, return 422 on line one would pass every refusal test
testTheTokenIsVerifiedAgainstTheResolvedEndpoint	the token is checked against that sender's stored credentials, so one configured system cannot impersonate another

Why it was untestable

$rawXml = (string)file_get_contents(filename: 'php://input');

OCP\IRequest exposes no raw-body accessor, so there was no seam. Added a protected readRawBody() the test overrides. Production path unchanged — same call, one indirection.

The URL is a wire contract, so the old one still answers

/api/stuf/inbound is canonical. /api/stuf/inkomend remains as an explicitly deprecated alias routed to the same method, because that URL lives in the upstream zaaksysteem's configuration, not ours — renaming it alone turns a working webhook into a silent 404 on somebody else's schedule. The alias is commented as a migration step with an end.

If procest isn't deployed anywhere yet, say so and I'll drop the alias — it's the one line still carrying the Dutch spelling.

Dutch that is deliberately NOT in this PR

These are stored data values, so changing them is a data migration, not a rename:

• 'direction' => 'inkomend' — ContactMomentController, ContactMomentService, StufMessageHandler
• "enum": ["uitgaand", "inkomend"] — register.d/80-stuf-zkn-outbound.json, procest_register.json, 40-kcc-werkplek.json

Existing rows carry those values; renaming the code without migrating the data breaks every read. They belong in the Dutch→English programme's data tranche.

Also still Dutch and also wire contracts: the sibling routes /api/stuf/zaken and /api/stuf/personen.

Verification

• php -l clean on all changed files.
• Full unit suite: 1904 tests, 8007 assertions, 0 failures (run on PHP 8.4 in the container — this box has 8.2 and the app requires ^8.3).
• No stale reference to stuf#inkomend, ->inkomend( or function inkomend anywhere in lib/, tests/ or appinfo/; the only surviving inkomend is the deliberate alias URL.

Closes #843.

🤖 Generated with Claude Code

[github-actions]

Quality Report — ConductionNL/procest @ c00e8b0

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
check-manifest		✅
check-vue3-compile		✅
test-l10n		✅
format		✅
composer			✅	✅ 104/104
npm			✅	✅ 535/535
app:check-code	⏭️
info.xml	✅
REUSE	❌
PHPUnit					✅
Newman					⏭️
Playwright					❌
Hydra gates					❌

---

Quality workflow — 2026-08-14 20:08 UTC

Download the full PDF report from the workflow artifacts.

[github-actions]

Quality Report — ConductionNL/procest @ 18477c8

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
check-manifest		✅
check-vue3-compile		✅
test-l10n		✅
format		✅
composer			✅	✅ 104/104
npm			✅	✅ 535/535
app:check-code	⏭️
info.xml	✅
REUSE	❌
PHPUnit					✅
Newman					⏭️
Playwright					✅
Hydra gates					❌

---

Quality workflow — 2026-08-14 21:27 UTC

Download the full PDF report from the workflow artifacts.