refactor(procest): translate 16 Dutch property names, and hold one back - #848
Merged
Conversation
procest carried 34 Dutch names after tranche 2 — the largest remaining
set in the fleet. This takes the 16 that are plain properties. The other
18 need their own passes: 13 are also SCHEMA SLUGS and want the
RenameDutchSchemaSlugs treatment softwarecatalog established, 4 are
enum/lifecycle VALUES needing a data migration, and one is held back.
`omschrijving` is that one, and it is worth naming precisely, because
renaming the property renames THREE external contracts at once:
- a StUF WIRE element. The outbound builder emitted `<zkn:description />`
where the Key2Zaken integration expects `<zkn:omschrijving />`. The
adapter already does this correctly at the boundary — StufMessageParser
maps `//zkn:omschrijving` onto an internal `description` — so the wire
spelling is exactly what must NOT move.
- a CSV IMPORT COLUMN HEADER (`mandaatNummer,omschrijving,rolNaam,...`).
Existing import files would have stopped loading with "Missing required
CSV columns".
- an email TEMPLATE VARIABLE, `{{omschrijving}}`.
Six tests caught it. Renaming the property still wants doing, but each of
those three positions has to be pinned to the old spelling first, which
is a change of its own rather than a line in a rename map.
`triggerTerugvordering` was also a method, so its declaration moved by
hand — to `recoveryTrigger`, which is what the schema's own title
("Recovery Trigger") already called it, rather than the dictionary's
`triggerRecovery`.
Verified against a control built with `git archive origin/development`
(not `git stash` — that reverts uncommitted work only):
PHPUnit 1921 tests both sides, same 4 errors and 2 failures, none unique
to this change and the count unchanged so nothing stopped running.
phpstan clean, psalm "No errors found", phpmd clean, vitest 349, eslint 0
errors, l10n and manifest validators pass. Stale field references
unchanged at 11. Dutch names 34 -> 18.
rubenvdlinde
requested review from
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
August 15, 2026 09:04
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 535/535 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-15 09:22 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
procest carried 34 Dutch names after tranche 2 — the largest remaining set in the fleet. This takes the 16 that are plain properties.
The other 18 need their own passes: 13 are also schema slugs (they want the
RenameDutchSchemaSlugstreatment softwarecatalog #518 established), 4 are enum/lifecycle values needing a data migration, and one is held back.omschrijvingis held back, and it is worth naming preciselyRenaming that property renames three external contracts at once:
<zkn:description />where Key2Zaken expects<zkn:omschrijving />. The adapter already handles this correctly at the boundary —StufMessageParsermaps//zkn:omschrijvingonto an internaldescription— so the wire spelling is exactly what must NOT move.mandaatNummer,omschrijving,rolNaam,...— existing import files would stop loading with "Missing required CSV columns".{{omschrijving}}inCaseEmailService.Six tests caught it. Renaming the property still wants doing, but each of those three positions has to be pinned to the old spelling first — a change of its own, not a line in a rename map.
triggerTerugvorderingwas also a method, so its declaration moved by hand — torecoveryTrigger, which is what the schema's own title ("Recovery Trigger") already called it, rather than the dictionary'striggerRecovery.Verification, against a real control
The control was built with
git archive origin/development, notgit stash— stash reverts uncommitted work only, and on a branch with commits it hands back your own branch as the "control".