Skip to content

fix(ui): NcButton native-type is inert on @nextcloud/vue 9 — six forms never submitted #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenvdlinde merged 1 commit into from
Aug 4, 2026
Merged

fix(ui): NcButton native-type is inert on @nextcloud/vue 9 — six forms never submitted #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/goods-receipt-note/GoodsReceiptNoteForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@
<div class="grn-form__actions">
<NcButton
variant="primary"
native-type="submit"
type="submit"
:disabled="submitting || !canSubmit"
data-testid="grn-form-submit">
{{ submitting ? t('shillinq', 'Saving...') : t('shillinq', 'Save goods receipt') }}
Expand Down
2 changes: 1 addition & 1 deletion src/components/purchase-order/PurchaseOrderForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@
<div class="po-form__actions">
<NcButton
variant="primary"
native-type="submit"
type="submit"
:disabled="submitting"
data-testid="po-form-submit">
{{ submitting ? t('shillinq', 'Creating...') : t('shillinq', 'Create purchase order') }}
Expand Down
2 changes: 1 addition & 1 deletion src/views/DeadlineCalendarSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@

<div class="deadline-calendar-settings__actions">
<NcButton variant="primary"
native-type="submit"
type="submit"
:disabled="saving"
data-testid="deadline-settings-save">
{{ saving ? t('shillinq', 'Saving…') : t('shillinq', 'Save') }}
Expand Down
2 changes: 1 addition & 1 deletion src/views/bookings/BookingForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
</p>

<div class="booking-form__actions">
<NcButton variant="primary" native-type="submit" :disabled="submitting">
<NcButton variant="primary" type="submit" :disabled="submitting">
{{ submitting ? t('shillinq', 'Saving…') : t('shillinq', 'Create Booking') }}
</NcButton>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/views/settings/PipelinqIntegration.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
<div class="actions">
<NcButton
variant="primary"
native-type="submit"
type="submit"
:disabled="saving">
{{ saving ? t('shillinq', 'Saving…') : t('shillinq', 'Save') }}
</NcButton>
Expand Down
2 changes: 1 addition & 1 deletion src/views/settings/Settings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

<NcButton
variant="primary"
native-type="submit"
type="submit"
:disabled="saving">
{{ saving ? t('shillinq', 'Saving...') : t('shillinq', 'Save') }}
</NcButton>
Expand Down
Loading