fix(ci): make composer check:strict able to fail on tests

[rubenvdlinde]

Problem

test:unit and test:all ended in:

./vendor/bin/phpunit --colors=always || echo 'No PHP test suite in this repo (no phpunit.xml, no tests/) - skipping...'

phpunit's exit status was discarded unconditionally. The message happens to be true today — this repo is a Python ExApp wrapper with no PHP test suite — but the mechanism never checked that. It swallowed whatever phpunit did, so a real failure (now, or the day a test suite is added here) would look exactly like "no tests to run", and composer check:strict could not fail on tests.

That matters because check:strict is about to be the thing an agent checks before deciding its job is done. A step that cannot fail satisfies that instruction with a no-op.

Change

composer.json only. Guard on the actual precondition instead of masking the exit code:

if [ -f phpunit.xml ] || [ -f phpunit.xml.dist ]; then ./vendor/bin/phpunit --colors=always; else echo 'SKIPPED: no phpunit.xml in this repo - there is no PHP test suite to run'; fi

A genuinely absent suite is now a stated fact in the output, and a present-but-failing suite fails the gate.

Positive control — measured on this tree

PHP 8.3.32 container, vendor/ freshly installed from composer.lock, injecting a temporary phpunit.xml plus one deliberately failing test:

state	composer check:strict
old composer.json + failing test	exit 0 — ALL CHECKS PASSED; the failure printed and was swallowed by || echo
new composer.json + failing test	exit 1 — SOME CHECKS FAILED, naming test:all (Tests: 1, Assertions: 1, Failures: 1)
new composer.json, test removed	exit 0 — clean, with SKIPPED: no phpunit.xml in this repo

The temporary phpunit.xml and control test are not part of this PR — the diff is composer.json only.

State after this PR

composer check:strict exits 0 on this branch: lint, phpcs, phpmd, psalm and phpstan all pass, and test:all skips loudly. No findings needed fixing here.

Note on measurement

The first measurement round in this repo showed psalm failing with Cannot resolve stubfile path .../OCP/Capabilities/ICapability.php. That turned out to be an artefact of the shared local dev checkout (its vendor/nextcloud/ocp/OCP had been renamed to OCP.bak), not a repo defect. All numbers above are from a clean composer install.