fix: declare NC 32-34 and test every major in it - #143
Merged
Conversation
composer.json requires php ^8.3 and nextcloud/ocp dev-master, so this app has never been analysed against the NC 31 API surface. The 31 claim was advertised to the App Store and backed by nothing.
The matrix ran stable31 — below the floor even before it was raised — and had no stable34 leg at all, so the one major this app most needed to prove was the one nothing touched. gate-65 rule 11 now fails this disagreement.
Contributor
Quality Report — ConductionNL/app-versions @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ❌ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| build | ❌ | ||||
| composer | ✅ | ✅ 17/17 | |||
| npm | ❌ | ❌ | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ❌ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-12 18:50 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
appinfo/info.xml:min-version31 → 32nextcloud-test-refs:["stable31","stable32","stable33"]→["stable34","stable32","stable33"]Why the floor moves rather than the matrix gaining a stable31 leg
composer.jsonrequiresphp ^8.3andnextcloud/ocp dev-master, so this app hasnever been analysed against the NC 31 API surface — static analysis has always read
the tip. The
31ininfo.xmlwas advertised to the App Store and backed by nothing.Every core Conduction app declares
32–34.Why the matrix changes
The old list ran stable31 — below the floor even before this change raised it — and
had no stable34 leg at all. So the one major this app most needed to prove was the
one nothing touched, while a leg ran on a version it does not support.
stable34leads becausefromJSON(inputs.nextcloud-test-refs)[0]is read as thesingle server for newman, playwright, journeydoc-capture and the coverage guard.
How this was caught
gate-65 rule 11 (
ConductionNL/.github#393, merged today) fails when the testedmatrix disagrees with
info.xml. This repo was one of its first real findings:Both edits were validated with a parser before pushing — the XML through
ElementTree and the workflow through a YAML load asserting the resolved matrix — not
by grep.
Related
petstorehas the same shape and is not fixed here: it declares NC 28–34 whilerequiring
php ^8.3andnextcloud/ocp ^31, so it advertises five majors nothing hasever tested. It needs an
ocpbump and a lock regeneration as well, so it gets its ownchange.