Skip to content

[OPS-1301] Delete legacy capabilities_and_config.yaml (switching to baton-admin-managed) - #17

Merged
ennyjfrick merged 1 commit into
mainfrom
ennyfrick/ops-1301-delete-legacy-cac
Apr 30, 2026
Merged

[OPS-1301] Delete legacy capabilities_and_config.yaml (switching to baton-admin-managed)#17
ennyjfrick merged 1 commit into
mainfrom
ennyfrick/ops-1301-delete-legacy-cac

Conversation

@ennyjfrick

Copy link
Copy Markdown
Contributor

Why

This connector uses connectorrunner.WithDefaultCapabilitiesConnectorBuilder(V2), so it works with the modern generate-baton-metadata.yaml workflow without bespoke configuration. baton-admin#448 flips this connector to baton-admin-managed metadata; once that PR merges and the Pulumi fan-out runs, generate-baton-metadata.yaml will be deployed here and the legacy capabilities_and_config.yaml becomes a duplicate.

What

Removes .github/workflows/capabilities_and_config.yaml. After this lands together with baton-admin#448, only the modern baton-admin-managed metadata workflow remains.

Merge order

  1. baton-admin#448 merges → Pulumi fan-out deploys generate-baton-metadata.yaml here.
  2. This PR merges → legacy capabilities_and_config.yaml removed.

If this PR lands before step 1, the connector will temporarily have no metadata workflow, so coordinate the merge order.

Linear: OPS-1301

🤖 Generated with Claude Code

…aton-admin-managed)

This connector uses connectorrunner.WithDefaultCapabilitiesConnector
Builder(V2), so it can be switched to the modern baton-admin-managed
generate-baton-metadata.yaml workflow. baton-admin#448 enables that on
the baton-admin side; once Pulumi fan-out runs the modern workflow
will be deployed here and the legacy capabilities_and_config.yaml is a duplicate.

Linear: https://linear.app/ductone/issue/OPS-1301

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@ennyjfrick
ennyjfrick requested a review from a team April 30, 2026 17:45
@linear

linear Bot commented Apr 30, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Claude finished @ennyjfrick's task in 45s —— View job


PR Review: Delete legacy capabilities_and_config.yaml

  • Gather context and review PR changes
  • Analyze the deleted workflow file
  • Verify no other references to the deleted file
  • Post review feedback

LGTM — this is a clean, single-file deletion with clear rationale.

What I verified

  1. The connector uses the modern builder. Confirmed connectorrunner.WithDefaultCapabilitiesConnectorBuilderV2 in cmd/baton-github-enterprise/main.go, so it's compatible with the generate-baton-metadata.yaml workflow without bespoke config.

  2. No references to the deleted workflow file. No other files in the repo reference capabilities_and_config.yaml.

  3. RELENG_GITHUB_TOKEN is still used elsewhere. It appears in release.yaml and verify.yaml, so removing this workflow doesn't orphan the secret — it's still needed.

  4. The replacement workflow (generate-baton-metadata.yaml) is not yet deployed here. This is expected per the PR description — baton-admin#448 must merge first so the Pulumi fan-out deploys it. The merge-order note in the PR body is accurate and important.

  5. Generated artifacts (baton_capabilities.json, config_schema.json) still exist in the repo. The replacement workflow will continue to maintain them, so no gap there once deployed.

One note

The deleted file was missing a trailing newline (the last line ends without \n). Not a concern since the file is being removed, just noting it was already non-conformant.

Merge-order risk

As the PR description correctly calls out: if this merges before baton-admin#448, the connector will temporarily have no metadata workflow. The PR description documents this clearly — just flagging it here so reviewers are aware this is a coordinated change.

No changes requested. Ship it (after baton-admin#448 merges). :shipit:

@ennyjfrick
ennyjfrick merged commit b784f2b into main Apr 30, 2026
8 checks passed
@ennyjfrick
ennyjfrick deleted the ennyfrick/ops-1301-delete-legacy-cac branch April 30, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants