Skip to content

Sanitize INI values to in AWS config #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pquerna merged 1 commit into from
Apr 8, 2026
+23 −3
Merged

Sanitize INI values to in AWS config #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions cmd/cone/aws.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,9 @@ func createAWSProfile(entitlement *shared.AppEntitlement, resource *shared.AppRe
return "", fmt.Errorf("entitlement is nil")
}

appID = sanitizeINIValue(appID)
entitlementID = sanitizeINIValue(entitlementID)

var accountID string
for _, value := range entitlement.SourceConnectorIds {
parts := strings.Split(value, "|")
Expand All @@ -202,20 +205,21 @@ func createAWSProfile(entitlement *shared.AppEntitlement, resource *shared.AppRe
break
}
}
accountID = sanitizeINIValue(accountID)
if accountID == "" {
return "", fmt.Errorf("could not extract AWS account ID from sourceConnectorIds")
}

if entitlement.DisplayName == nil {
return "", fmt.Errorf("entitlement has no display name")
}
roleName := strings.Split(*entitlement.DisplayName, " ")[0]
roleName := sanitizeINIValue(strings.Split(*entitlement.DisplayName, " ")[0])

accountName := "aws"
if resource != nil && resource.DisplayName != nil {
accountName = strings.ToLower(strings.ReplaceAll(*resource.DisplayName, " ", "-"))
accountName = sanitizeINIValue(strings.ToLower(strings.ReplaceAll(*resource.DisplayName, " ", "-")))
}
profileName := fmt.Sprintf("%s-%s", accountName, strings.ToLower(roleName))
profileName := sanitizeINIValue(fmt.Sprintf("%s-%s", accountName, strings.ToLower(roleName)))

awsConfigDir := filepath.Join(os.Getenv("HOME"), ".aws")
if err := os.MkdirAll(awsConfigDir, 0700); err != nil {
Expand Down Expand Up @@ -513,6 +517,22 @@ func extractDuplicateTaskID(errMsg string) string {
return ""
}

// sanitizeINIValue strips characters that could break INI structure or enable
// injection when API-derived values are interpolated into ~/.aws/config.
func sanitizeINIValue(s string) string {
var b strings.Builder
b.Grow(len(s))
for _, r := range s {
switch r {
case '\n', '\r', '\x00', '[', ']', '"', '\\':
continue
default:
b.WriteRune(r)
}
}
return b.String()
}

func extractProfileConfig(config, profileSection string) string {
lines := strings.Split(config, "\n")
var profileLines []string
Expand Down
Loading