refactor(communications): port bulk push send APIs from v0.16.x (#1476)#1485
Merged
Conversation
Backport the push provider batching work landed on v0.16.x after the communications module split, including FCM multicast, SNS concurrency batching, OneSignal bulk sends, success-based metrics, and the grpc-sdk sendManyNotifications array type fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #1476 to the v0.17 communications module. The comms split (#1471) copied push providers from the pre-#1476 snapshot on
v0.16.x, so bulk send improvements never landed onmain.This PR brings over:
sendEachForMulticastwith permanent-token-only cleanup and corrected loggingsendMessagesvia a single API callpush_notifications_sent_totalmetrics on gRPC bulk routessendManyNotificationsarray type fix ({...}[]instead of tuple)Tasks:
sendManyNotificationstypingWhat kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
mainbranchfix #xxx, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Follow-up to #1476 (merged on
v0.16.xas v0.16.27). No grpc-sdk module target changes — communications client wiring stays onCommunicationsDefinition.