Skip to content

refactor(communications): port bulk push send APIs from v0.16.x (#1476)#1485

Merged
kkopanidis merged 1 commit into
mainfrom
refactor/comms-bulk-push-port
Jun 11, 2026
Merged

refactor(communications): port bulk push send APIs from v0.16.x (#1476)#1485
kkopanidis merged 1 commit into
mainfrom
refactor/comms-bulk-push-port

Conversation

@kkopanidis

Copy link
Copy Markdown
Contributor

Ports #1476 to the v0.17 communications module. The comms split (#1471) copied push providers from the pre-#1476 snapshot on v0.16.x, so bulk send improvements never landed on main.

This PR brings over:

  • Chunked/concurrent batch dispatch in the push base provider
  • Firebase sendEachForMulticast with permanent-token-only cleanup and corrected logging
  • Amazon SNS concurrent batch sends with endpoint error handling
  • OneSignal bulk sendMessages via a single API call
  • Success-based push_notifications_sent_total metrics on gRPC bulk routes
  • grpc-sdk sendManyNotifications array type fix ({...}[] instead of tuple)

Tasks:

  • Port batch interfaces and base provider dispatch
  • Port Firebase, Amazon SNS, and OneSignal provider implementations
  • Delegate push service to provider aggregate methods
  • Align gRPC handlers (validation + metrics)
  • Fix grpc-sdk sendManyNotifications typing

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature

Other information:

Follow-up to #1476 (merged on v0.16.x as v0.16.27). No grpc-sdk module target changes — communications client wiring stays on CommunicationsDefinition.

Backport the push provider batching work landed on v0.16.x after the
communications module split, including FCM multicast, SNS concurrency
batching, OneSignal bulk sends, success-based metrics, and the grpc-sdk
sendManyNotifications array type fix.
@kkopanidis
kkopanidis merged commit 1eb8863 into main Jun 11, 2026
7 checks passed
@kkopanidis
kkopanidis deleted the refactor/comms-bulk-push-port branch June 11, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant