feat(routing): raw headers and opt-in raw body for webhook verification#1488
Merged
Conversation
Enable webhook signature verification by piping sanitized req.rawHeaders through gRPC and adding captureRawBody for unmodified request bytes. Co-authored-by: Cursor <cursoragent@cursor.com>
Clear CodeFactor no-unused-vars findings for Request and Indexable. Co-authored-by: Cursor <cursoragent@cursor.com>
ChrisPdgn
marked this pull request as ready for review
June 19, 2026 13:48
Add captureRawHeaders opt-in flag, urlencoded rawBody verify, per-route gating with early buffer release, and defensive sanitizeRawHeaders guard.
Contributor
|
@ChrisPdgn — follow-up commit pushed addressing review feedback from the three-horsemen review:
Webhook routes should use both: .captureRawBody(true)
.captureRawHeaders(true)Ready for your review when you have a moment. |
Add express.raw() middleware before express.json() so routes with captureRawBody: true receive rawBody for application/xml, application/octet-stream, and other non-standard content types. Co-authored-by: Cursor <cursoragent@cursor.com>
…-capture-gating-6d8d fix(routing): capture raw body for non-JSON webhook content types
kkopanidis
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rawHeadersand opt-inrawBodythrough Hermes/gRPC so webhook routes can verify signatures.captureRawBodyto routing types and proto definitions, including the follow-up proto fix.rawHeaders.Test plan
captureRawBody: truerawHeaders