Skip to content

fix(grpc): return {} for google.protobuf.Empty responses#1493

Merged
kkopanidis merged 1 commit into
mainfrom
fix/grpc-empty-response-serialization
Jun 19, 2026
Merged

fix(grpc): return {} for google.protobuf.Empty responses#1493
kkopanidis merged 1 commit into
mainfrom
fix/grpc-empty-response-serialization

Conversation

@kkopanidis

Copy link
Copy Markdown
Contributor

Summary

  • Return callback(null, {}) instead of null/undefined for all google.protobuf.Empty gRPC handlers.
  • Fixes database startup crash on RegisterAdminRoute after the protobufjs 8 upgrade (Empty: object expected).
  • Adds the missing success callback in router patchRouteMiddlewares.
  • Aligns handler typings with Empty responses (Record<string, never> / Empty).

Test plan

  • pnpm exec turbo run build --filter=@conduitplatform/core --filter=@conduitplatform/database --filter=@conduitplatform/router --filter=@conduitplatform/chat --filter=@conduitplatform/authorization
  • Confirm database module stays up on standalone/docker startup (no RegisterAdminRoute crash)

protobufjs 8 rejects null/undefined when serializing Empty messages, which
crashed the database module on RegisterAdminRoute during startup.
@kkopanidis
kkopanidis merged commit 8e5fd54 into main Jun 19, 2026
7 checks passed
@kkopanidis
kkopanidis deleted the fix/grpc-empty-response-serialization branch June 19, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant