fix(communications): persist legacy email/push/sms config during migration#1498
Merged
Conversation
…ation Add core DeleteConfig RPC so communications can remove email/push/sms namespaces from Redis and MongoDB after merging. Legacy keys gate migration via state checks; cleanup runs in onConfig after config is persisted.
Communications has no test runner wired in package.json; drop the standalone test file from the migration PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preConfigonly when the channel is still at defaults, so existing communications settings are not overwritten.active: true; legacyactive: falseis preserved.email/pushNotifications/smsconfigs from Redis and MongoDB via new coreDeleteConfigRPC so migration does not run again.Test plan