fix(communications,storage): SMS provider field, email status job, Azure folder metric#1504
Merged
Merged
Conversation
…ure folder metric Persist configured SMS provider on records. Wire the email status worker to the real ESP via communications gRPC. Decrement Azure folder metrics on delete.
kkopanidis
force-pushed
the
fix/bug-batch-comms-storage
branch
from
June 21, 2026 15:45
0c9f060 to
438db77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
mainbranchfix #xxx, where "xxx" is the issue number)Summary
SMS message records always stored
provider: 'unknown'even when Twilio, AWS SNS, or MessageBird was configured.The BullMQ email status worker still returned a hardcoded SendGrid stub after the communications module migration, so delivery status never reflected the configured ESP.
Azure storage
deleteFolderincrementedfolders_totalinstead of decrementing it, unlike every other provider.Track the configured SMS provider name on
SmsServiceand persist it on newSmsRecorddocuments.Point the sandboxed status worker at the communications gRPC
getEmailStatuspath, map responses with the configured transport, and skip status polling for SMTP and Amazon SES.Use
decrement('folders_total')in AzuredeleteFolder.Test plan
GET /sms/messagesshowsprovider: twilioEmailRecord.statusupdates after the status job runsfolders_totalreturns to the prior valueOther information: