feat(chat): add file attachments to sendMessage gRPC#1541
Merged
Conversation
Allow module-to-module chat sends to pass storage file IDs through sendMessage, with validation and socket broadcast parity for file and multimedia messages. Co-authored-by: Cursor <cursoragent@cursor.com>
| }); | ||
| } | ||
|
|
||
| if (isFileMessage && !Array.isArray(requestFiles)) { |
Contributor
There was a problem hiding this comment.
this array check is a little bit redundant. requestFiles is always an array since you normalize it with const requestFiles = files ?? []; , and files are always an array or missing from protobuff
other than this minor thing (doesnt hurt, but this if clause wont ever run), I think this is good to go, I will approve either way
ioanniskemerlis
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Adds storage file ID support to the chat module
sendMessagegRPC API so trusted server-side callers can sendfileandmultimediamessages with the same semantics as socket messages.SendMessageRequestinchat.protowithrepeated string files = 6file/multimediamessages require at least one file IDfilesonly when file IDs are presentFixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
pnpm --filter @conduitplatform/chat run generateTypes,pnpm --filter @conduitplatform/grpc-sdk run protoc)Chat.tshas no new linter issuesTest Configuration:
@conduitplatform/grpc-sdkonv0.16.xChecklist: