docs: state what a uid actually guarantees - #11
Conversation
|
Warning Review limit reached
Next review available in: 29 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The glossary said a resource is identified "uniquely by metadata.uid", which is looser than spec §1: the Kubernetes guarantee is per cluster, so the protocol scopes uid to one upstream target and a consumer holding more than one stream keys on (target, uid). Two sentences, not two paragraphs — the detail is a footnote, but the contract is the contract and the glossary should not quietly widen it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
3af3c07 to
5d8c4ac
Compare
Prompted by the question "a Kubernetes uid is globally unique, isn't it?" — and the honest answer is almost, in a way that matters here.
What Kubernetes actually guarantees: every object created over the whole lifetime of one cluster has a distinct
uid. Unique in space and in time. The time half is what earnsuidthe key in this library: a resource deleted and recreated under the same name is a different object, and a store keyed onnamewould reattach a user's unsaved draft to it.What it does not guarantee: global uniqueness. The guarantee is cluster-scoped. In practice a
uidis a UUID, so a cross-cluster collision is not a thing that happens — but the protocol doesn't lean on that, and spec §1 already takes the strict line: auidis unique within one upstream target, and a consumer holding objects from more than one stream MUST key on(target, uid).So the spec was right and the glossary was wrong. docs/glossary.md said a resource is identified "uniquely by
metadata.uid", full stop — looser than the spec it is supposed to introduce, and exactly the sentence that would let a reader merge two targets into one store. It now states the real guarantee, says why the time half is the load-bearing one, notes that(target, uid)is the key across streams, and points at the spec.Docs only.
🤖 Generated with Claude Code