fix(rsql): patch vendored ethnum 1.5.2 -> 1.5.3 for rustc 1.96#128
Merged
Conversation
ethnum <=1.5.2 fabricates a TryFromIntError via mem::transmute(()), relying on it being zero-sized. rustc 1.96 (nixos-unstable) gave the type a field, so the transmute is now a size mismatch (E0512) and rsql fails to build. 1.5.3 replaces the hack with u8::try_from(-1i8).unwrap_err(). rsql 0.19.4 is already the latest release, so bump the transitive dep via a Cargo.lock patch and refresh cargoHash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every CI build on
masterfails compilingrsqlon the currentnixos-unstable:ethnum <=1.5.2fabricates aTryFromIntErrorviamem::transmute(()), relying on the type being zero-sized. rustc 1.96 gave it a field, so the transmute is now a size mismatch.ethnum 1.5.3replaces the hack withu8::try_from(-1i8).unwrap_err().This surfaced only after the
nixos-unstablechannel crossed the rustc bump — PR checks were green because cachix still had the oldrsqldrv (nix-build-uncachedskipped it); once the channel moved, the drv hash changed, cache-missed, and the compile actually ran.Fix
rsql 0.19.4is already the latest release, so bump the transitive dep via aCargo.lockpatch (ethnum.patch) and refreshcargoHash.Verified locally on aarch64-darwin:
nix build .#rsqlsucceeds,rsql --version->rsql/0.19.4. This PR's own CI is a real cache-miss build (drv hash changed), so it validates x86_64-linux too.