[AT-176]: Add questionTopic parameter to PIA question tracking events - #475
Merged
Mudaafi merged 2 commits intoJul 21, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for an optional questionTopic field to Product Insights Agent (PIA) question tracking events so callers can associate question click/submit events with a topic/category.
Changes:
- Extend
trackProductInsightsAgentQuestionClickandtrackProductInsightsAgentQuestionSubmitto acceptquestionTopicand send it asquestion_topicin the request body. - Update TypeScript definitions for both methods to include
questionTopic?: string. - Add/extend spec assertions to verify
question_topicis sent whenquestionTopicis provided.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/types/tracker.d.ts | Adds questionTopic?: string to the parameter types for the two PIA question tracking methods. |
| src/modules/tracker.js | Accepts questionTopic and maps it to bodyParams.question_topic for click/submit events. |
| spec/src/modules/tracker.js | Adds coverage asserting question_topic is present in the request body when provided. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LINEAR: https://linear.app/constructor/issue/AT-176/js-client-add-question-topic-to-pia-tracking-events